[SYCL] Enable builds on macOS host #6706
Conversation
|
Test build logs for CI run should be available here soon: https://github.com/alexbatashev/llvm/runs/8201358091?check_suite_focus=true |
| @@ -31,7 +31,6 @@ list(APPEND SYCL_TEST_DEPS | |||
| sycl-toolchain | |||
| FileCheck | |||
| not | |||
| get_device_count_by_type | |||
There was a problem hiding this comment.
Is it dead? I thought we use it in either in-tree LIT or llvm-test-suite tests.
There was a problem hiding this comment.
I thought so, too. Turns out, there's not a single mention of this tool, other than these, that I'd removed. It was dead for a long time now. LLVM Test Suite does not check for devices at all, fully relying on user input, and device-dependent tests have been removed from this repo.
alexbatashev
added
the
disable-lint
|
No idea why clang-format is triggered by a file, that is not changed in this PR |
I suppose it's due to this change: #6652. There is a new way to generate the diff, which I suspect might be the reason of this. |
|
@intel/llvm-reviewers-runtime friendly ping |
|
Both fails seem to be true for other PRs/commits. Tracker for hung config: #6732 |
| #define __SYCL_OPENCL_PLUGIN_NAME "libpi_opencl.so" | ||
| #define __SYCL_LEVEL_ZERO_PLUGIN_NAME "libpi_level_zero.so" | ||
| #define __SYCL_CUDA_PLUGIN_NAME "libpi_cuda.so" | ||
| #define __SYCL_ESIMD_EMULATOR_PLUGIN_NAME "libpi_esimd_emulator.so" | ||
| #define __SYCL_HIP_PLUGIN_NAME "libpi_hip.so" | ||
| #elif defined(__SYCL_RT_OS_DARWIN) |
There was a problem hiding this comment.
Nit: I wonder if we simply need to define a suffix (like .dll, .so or .dylib) to use it in library names instead of duplicating almost the same lines three times
There was a problem hiding this comment.
The right way to do this is to autogenerate these names from CMake, but that'd be outside of the scope of this patch.
|
@alexbatashev, could you resolve merge conflicts, please? |
|
@alexbatashev, probably another merge is required. Could you take look at pre-commit failures, please? |
This tool is not needed, we stopped building it a while back in #6706
This patch contains minimal changes to make compiler toolchain builds succeed on macOS:
The above changes are far from fully working SYCL on Darwin targets, this patch only fixes toolchain builds, and does not attempt to make the toolchain itself functional.
Fixes #258
Fixes #982