Skip to content

fix: cannot resolve the ast messages which has json path for v9 #2162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 5, 2025

Conversation

kazupon
Copy link
Member

@kazupon kazupon commented Apr 5, 2025

ref #2156

@kazupon kazupon requested a review from Copilot April 5, 2025 18:04
@kazupon kazupon added the Type: Bug Bug or Bug fixes label Apr 5, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 14 out of 14 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (2)

packages/core-base/src/resolver.ts:354

  • The early return here may prematurely stop the resolution while traversing AST keys. Consider revisiting this logic to ensure it doesn't mask valid values when keys match AST_NODE_PROPS_KEYS.
if (AST_NODE_PROPS_KEYS.includes(key) && isMessageAST(last)) {

packages/core-base/test/translate.test.ts:995

  • [nitpick] The test for JSON path keys is currently skipped. Consider adding a comment clarifying the conditions for enabling this test to ensure it is revisited when the fix is verified.
test.skip('json path key', () => {

Copy link

cloudflare-workers-and-pages bot commented Apr 5, 2025

Deploying vue-i18n-next with  Cloudflare Pages  Cloudflare Pages

Latest commit: 21d08f9
Status: ✅  Deploy successful!
Preview URL: https://b0d7b829.vue-i18n-next.pages.dev
Branch Preview URL: https://fix-resolve-ast-message-v9.vue-i18n-next.pages.dev

View logs

@kazupon kazupon merged commit 15f735d into v9 Apr 5, 2025
19 checks passed
@kazupon kazupon deleted the fix/resolve-ast-message-v9 branch April 5, 2025 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug Bug or Bug fixes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant