Skip to content

fix: unnecessary changes to upload-crashlytics-symbols script each time configure project #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2025
+9 −8
Merged

fix: unnecessary changes to upload-crashlytics-symbols script each time configure project #391

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 9 additions & 8 deletions packages/flutterfire_cli/lib/src/firebase/firebase_apple_writes.dart
View file
Original file line number Diff line number Diff line change
@@ -404,22 +404,23 @@ fi
flutterfire upload-crashlytics-symbols --upload-symbols-script-path="\$PATH_TO_CRASHLYTICS_UPLOAD_SCRIPT" --platform=$platform --apple-project-path="\${SRCROOT}" --env-platform-name="\${PLATFORM_NAME}" --env-configuration="\${CONFIGURATION}" --env-project-dir="\${PROJECT_DIR}" --env-built-products-dir="\${BUILT_PRODUCTS_DIR}" --env-dwarf-dsym-folder-path="\${DWARF_DSYM_FOLDER_PATH}" --env-dwarf-dsym-file-name="\${DWARF_DSYM_FILE_NAME}" --env-infoplist-path="\${INFOPLIST_PATH}" $projectType
)

for target in project.targets
for target in project.targets
if (target.name == '$target')
phase = target.shell_script_build_phases().find do |item|
if defined? item && item.name
item.name == runScriptName
end
end

if (!phase.nil?)
phase.remove_from_project()
if phase.nil?
phase = target.new_shell_script_build_phase(runScriptName)
phase.shell_script = bashScript
project.save()
elsif phase.shell_script != bashScript
phase.shell_script = bashScript
project.save()
end

phase = target.new_shell_script_build_phase(runScriptName)
phase.shell_script = bashScript
project.save()
end
end
end
''';
}