Skip to content

fixing some systemd configs #162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: debian-master
Choose a base branch
from
Open

fixing some systemd configs #162

wants to merge 1 commit into from

Conversation

joelanders
Copy link

  1. I removed the curly-brackets from the tlsdated.service file because otherwise DAEMON_OPTS="-f some/file" ends up getting sent to tlsdated as one argument instead of two. (and DAEMON_OPTS="" is interpreted as one argument instead of zero.)

  2. I copy the /etc/default/tlsdated file to where it's being expected, because otherwise systemd throws an error when it looks for EnvironmentFile.

Never done any debian packaging, so the style's probably off. Probably the .service and .default file should be moved in the Makefile, since they're in upstream tlsdate now?

@kartikm
Copy link
Contributor

kartikm commented Nov 18, 2014

LGTM

@ioerror
Copy link
Owner

ioerror commented Jan 5, 2015

I'd like to see what @h01ger thinks of these changes?

@dkriegner
Copy link

I think that the changes in the systemd service file should be merged asap. The presence of the brackets cause the daemon to fail to set the time. The error in the logs is

Apr 17 09:28:47 helda tlsdated[1770]: initial time sync type: system-clock
Apr 17 09:28:47 helda tlsdated[1770]: synced rtc to sysclock
Apr 17 09:28:47 helda tlsdated[1770]: [event:handle_time_setter] time set from the system-clock (1429255727)
Apr 17 09:28:47 helda tlsdated[1770]: [tlsdate-monitor] execve() failed: No such file or directory
Apr 17 09:29:07 helda tlsdated[1770]: [tlsdate-monitor] execve() failed: No such file or directory
Apr 17 09:29:07 helda tlsdated[1775]: [tlsdate-monitor] execve() failed: No such file or directory
Apr 17 09:29:47 helda tlsdated[1770]: [tlsdate-monitor] execve() failed: No such file or directory
Apr 17 09:29:47 helda tlsdated[1800]: [tlsdate-monitor] execve() failed: No such file or directory

I observed this on Gentoo (see Gentoo bug 533380), but I think this might be the same on Debian's bug 778776

@ghost
Copy link

ghost commented Nov 7, 2016

This fixed my issue as well on Raspbian. Why hasn't this been merged and the issue closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants