Skip to content

feat(badge): add hue property for the ionic theme #30307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 40 commits into from
Apr 11, 2025
Merged

Conversation

brandyscarney
Copy link
Member

@brandyscarney brandyscarney commented Mar 26, 2025

Issue number: internal


What is the current behavior?

The badge component does not support the hue property.

What is the new behavior?

Adds support for the subtle hue for the badge. Defaults to subtle when the badge contains icon or text. Defaults to bold when the badge is empty or when it is inside of a button or tab button.

Does this introduce a breaking change?

  • Yes
  • No

Other information

Hue Preview
Hint Preview

Copy link

vercel bot commented Mar 26, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
ionic-framework ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 11, 2025 4:51pm

@github-actions github-actions bot added package: core @ionic/core package package: angular @ionic/angular package package: vue @ionic/vue package labels Mar 26, 2025
@brandyscarney brandyscarney changed the title feat(badge): add subtle hue for the ionic theme feat(badge): add hue property for the ionic theme Apr 2, 2025
@brandyscarney brandyscarney marked this pull request as ready for review April 7, 2025 19:20
@brandyscarney brandyscarney requested a review from a team as a code owner April 7, 2025 19:20
@brandyscarney brandyscarney requested review from ShaneK and removed request for a team April 7, 2025 19:20
Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, comments aren't blockers

@brandyscarney brandyscarney changed the base branch from FW-6252 to next April 11, 2025 16:28
@brandyscarney brandyscarney merged commit a9aa59b into next Apr 11, 2025
48 checks passed
@brandyscarney brandyscarney deleted the FW-6252-badge branch April 11, 2025 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
package: angular @ionic/angular package package: core @ionic/core package package: vue @ionic/vue package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants