Skip to content

breaking: modernize project #1447

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 39 commits into from
May 2, 2025

Conversation

christian-bromann
Copy link
Member

@christian-bromann christian-bromann commented Apr 16, 2025

This patch will modernize the Ionicons project, it includes the following changes:

Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cheat sheet has broken links when clicking on an icon, might be worth fixing.

It might beneficial to add more comments of what's going on. We don't often work in this repo so comments would be a nice refresher.

christian-bromann and others added 6 commits April 29, 2025 08:02
Co-authored-by: Brandy Smith <brandyscarney@users.noreply.github.com>
Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
Co-authored-by: Maria Hutt <thetaPC@users.noreply.github.com>
@christian-bromann
Copy link
Member Author

@brandyscarney @thetaPC thanks for the review, I've addressed the feedback.

Co-authored-by: Brandy Smith <brandyscarney@users.noreply.github.com>
christian-bromann and others added 2 commits April 29, 2025 10:17
Co-authored-by: Brandy Smith <brandyscarney@users.noreply.github.com>
Co-authored-by: Brandy Smith <brandyscarney@users.noreply.github.com>
Co-authored-by: Brandy Smith <brandyscarney@users.noreply.github.com>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you know why fill="currentColor" was added to these 3 svgs? I don't see it in any others except for src/svg/chevron-collapse-sharp.svg

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It was requested in some of the issues I triaged. Do you have any concerns with the change?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshot 2025-04-29 at 1 22 38 PM

I tested setting color on each of them without fill="currentColor" and they seem to still work fwiw

Copy link
Member

@brandyscarney brandyscarney Apr 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I didn't see your reply when I added my 2nd comment. We ran into some issues in the past with stroke:#000 being added to the svgs and it caused issues with being able to override the color, so I am always overly cautious here, but this change shouldn't do that.

I am curious how to reproduce the problem in #1420 though because I tried setting the color directly and still see it inheriting on the dots:

<ion-icon style="color: red" name="bowling-ball-outline"></ion-icon>
<ion-icon style="color: red" name="chevron-collapse-sharp"></ion-icon>
<ion-icon style="color: red" name="information-circle-outline"></ion-icon>
<ion-icon style="color: red" name="warning-outline"></ion-icon>

<ion-icon color="primary" name="bowling-ball-outline"></ion-icon>
<ion-icon color="secondary" name="chevron-collapse-sharp"></ion-icon>
<ion-icon color="tertiary" name="information-circle-outline"></ion-icon>
<ion-icon color="success" name="warning-outline"></ion-icon>

Screenshot 2025-04-29 at 1 37 56 PM

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's a related issue: #1129

Copy link
Member

@brandyscarney brandyscarney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good in my testing! Non-blocking comment on the svgs adding fill="currentColor".

It might be helpful if we add a note in the Contributing guide on how to setup and run the Playwright tests (including installing Playwright), but I don't think it's required for this PR.

Thanks for doing this! Great work. 🚀

One thing to note — we should discuss whether or not this should be merged into main or if we should put it into a feature branch.

Copy link
Contributor

@thetaPC thetaPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I only have a non-blocking comment.

@christian-bromann
Copy link
Member Author

we should discuss whether or not this should be merged into main or if we should put it into a feature branch.

Can you elaborate on this?

@brandyscarney
Copy link
Member

As discussed offline, this will be merged into main and released as a major.

@christian-bromann christian-bromann merged commit e04eccc into ionic-team:main May 2, 2025
6 checks passed
@christian-bromann christian-bromann deleted the cb/update branch May 2, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants