Add support for linked clones #478
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasK32
requested review from
65278,
avorima,
pborn-ionos,
mcbenjemaa and
wikkyk
as code owners
TestsPlease note that running unit and e2e tests requires manual approval from a team member. e2e testsWe use labels to control which e2e tests contexts are run:
ℹ️ Ask a team member to add the requested labels if you don't have enough permissions. |
mcbenjemaa
reviewed
Apr 30, 2025
mcbenjemaa
reviewed
Apr 30, 2025
|
|
||
| Expect(k8sClient.Create(context.Background(), dm)).Should(MatchError(ContainSubstring("Must set full=true when specifying storage"))) | ||
| }) | ||
|
|
There was a problem hiding this comment.
Can you add a test case for a linked clone?
Yes, tested both using linked clones as well as full clones |
|
Please Rebase and we are good to go. |
Previous rule required 'full' to be always set to 'true' and did not validate for 'storage' being set. Signed-off-by: Lukas Kirylak <[email protected]>
Moving validation rules to VirtualMachineCloneSpec also adds them to other resources where it is embedded that users interact with directly. Signed-off-by: Lukas Kirylak <[email protected]>
Having 'format' default to 'raw' prevents making linked clones on storages that support it. Signed-off-by: Lukas Kirylak <[email protected]>
Signed-off-by: Lukas Kirylak <[email protected]>
|
Rebased 👍 |
mcbenjemaa
approved these changes
May 6, 2025
|
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#174
Description of changes:
ProxmoxMachineSpecvalidation rulesfullto be always set totrueand did not validate forstoragebeing setProxmoxMachinetoVirtualMachineCloneSpecVirtualMachineCloneSpecalso adds them to other resources where it is embedded that users interact with directlyVirtualMachineCloneSpec.Formatformatdefault torawprevents making linked clones on storages that support itTesting performed:
make test