-
Notifications
You must be signed in to change notification settings - Fork 7
feat: consistent wait across all commands #506
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
avirtopeanu-ionos
wants to merge
34
commits into
master
Choose a base branch
from
feat/wait
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6765d6b
to
0e37ebd
Compare
…elp which cobra redirects to a blank command
183b043
to
6252289
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds global
--wait / -w
flag.Adds per-command
--timeout
flag and also-t
shorthand if it is not already defined. (We cannot add a global --timeout flag while conditionally adding-t
shorthand - there are some commands that already define this-t
shorthand for something else.)Adds a
httpClient
which we use to dynamically wait based on the retrieved hrefWe can find the href by pausing (catch the output in a buffer) after executing a command, and then working from there with what info we caught through the printer pkg. If we don't have the href yet, try running the equivalent
get
command with whatever flags are common between the two commands.KNOWN ISSUES
The default timeout might be too low. It is consistently not enough for kubernetes resources, and the resources are still DEPLOYING when the waiting ends.
if using --wait: