-
Notifications
You must be signed in to change notification settings - Fork 128
Combine "Install" and "Implementations" #348
Conversation
Revises implementations section to a single install section and adjusts headers accordingly. Rearranges sections. Note we'll have to modify headers on blog if we go this route.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The install panel feels more scannable than the layout that's currently live. Given that — and the usefulness of the captions that accompany each implementation — do you think it'd be better to link *here *from the top nav, rather than to the (still not great) install page on the docs site?
Here are some visual adjustments i think might be a further improvement …
- Reflow into two columns, to shorten line lengths and make the layout compact (my layout is super rough)
- Remove the borders
- Change the implementation labels to the
#6acad1
green link color - Use the current caption styling for the supporting text (16px @.6 alpha) (alternatively, keep the size at 18, but try the .6 alpha fill)
- Change the
IPFS Desktop
text link in the top caption to#6acad1
- Increase the contrast between the Companion callout image and the page background (eg by adjusting the image background ... don't stroke or shadow)
- Use a different image to represent desktop, such as a crop of the peers or status pages
layouts/partials/get-started.html
Outdated
@@ -2,7 +2,7 @@ | |||
<div class="container"> | |||
<div class="content-center mb2"> | |||
<h2>What do you want to do with IPFS?</h2> | |||
<h5>Choose the option below that best fits your goal, or <a href="https://github.com/ipfs-shipyard/ipfs-desktop">install IPFS Desktop</a> now.</h5> | |||
<h5>Choose the option below that best fits your goal, or <a href="https://github.com/ipfs-shipyard/ipfs-desktop" target="_blank">install IPFS Desktop</a> now.</h5> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why are we opening just this instance of the link on a new tab?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm still thinking that anything that goes off-site should open in a new tab.
@ericronne -- Do you mind having another look? Incorporated most of your edits, but the text screen opacity made things a little illegible. Thanks! |
@jessicaschilling i made some adjustments, lmk if they make any sense to you 🙏!
|
@ericronne Thanks! These all LGTM. Sad to lose the stars, but you're correct on legibility, and since we're getting close to reworking this site as a whole, this as a fix seems fine. And good call on removing the hover for the caption text ... this made sense when the items were in boxes, but less so now. @cwaring -- can you please have a look to hopefully bless this? Would be awesome to merge this Thursday. Thanks! |
I've checked this over and pushed a few tweaks to keep things tidy™ - please take a look and feel free to merge if you're happy. |
Thank you very much! |
Initial commit for review/discussion.
Revises implementations section to a single install section and adjusts
headers accordingly. Rearranges sections. Note we'll have to modify
headers on blog if we go this route.
ref #293