Skip to content
This repository was archived by the owner on Jul 5, 2021. It is now read-only.

Combine "Install" and "Implementations" #348

Merged
merged 9 commits into from
Nov 15, 2019

Conversation

jessicaschilling
Copy link
Contributor

@jessicaschilling jessicaschilling commented Nov 6, 2019

Initial commit for review/discussion.
Revises implementations section to a single install section and adjusts
headers accordingly. Rearranges sections. Note we'll have to modify
headers on blog if we go this route.
ref #293

Revises implementations section to a single install section and adjusts 
headers accordingly. Rearranges sections. Note we'll have to modify 
headers on blog if we go this route.
@jessicaschilling jessicaschilling self-assigned this Nov 6, 2019
@jessicaschilling jessicaschilling changed the title Initial commit for review/discussion Combine "Install" and "Implementations" Nov 6, 2019
@jessicaschilling jessicaschilling added topic/design-content Content design, writing, information architecture topic/design-front-end Front-end implementation of UX/UI work dif/easy Someone with a little familiarity can pick up Category: Content size/medium Size: Medium labels Nov 6, 2019
Copy link
Contributor

@ericronne ericronne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The install panel feels more scannable than the layout that's currently live. Given that — and the usefulness of the captions that accompany each implementation — do you think it'd be better to link *here *from the top nav, rather than to the (still not great) install page on the docs site?

Here are some visual adjustments i think might be a further improvement …

  • Reflow into two columns, to shorten line lengths and make the layout compact (my layout is super rough)
  • Remove the borders
  • Change the implementation labels to the #6acad1 green link color
  • Use the current caption styling for the supporting text (16px @.6 alpha) (alternatively, keep the size at 18, but try the .6 alpha fill)
  • Change the IPFS Desktop text link in the top caption to #6acad1
  • Increase the contrast between the Companion callout image and the page background (eg by adjusting the image background ... don't stroke or shadow)
  • Use a different image to represent desktop, such as a crop of the peers or status pages
    image

@@ -2,7 +2,7 @@
<div class="container">
<div class="content-center mb2">
<h2>What do you want to do with IPFS?</h2>
<h5>Choose the option below that best fits your goal, or <a href="https://github.com/ipfs-shipyard/ipfs-desktop">install IPFS Desktop</a> now.</h5>
<h5>Choose the option below that best fits your goal, or <a href="https://github.com/ipfs-shipyard/ipfs-desktop" target="_blank">install IPFS Desktop</a> now.</h5>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we opening just this instance of the link on a new tab?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm still thinking that anything that goes off-site should open in a new tab.

@jessicaschilling
Copy link
Contributor Author

@ericronne -- Do you mind having another look? Incorporated most of your edits, but the text screen opacity made things a little illegible. Thanks!

@ericronne
Copy link
Contributor

@jessicaschilling i made some adjustments, lmk if they make any sense to you 🙏!

  • Removed the stars. Unless we can dim them, they really impede readability.
  • Unlinked the description text (which struck me as a non-intuitive behavior), so that only the h4label and the thumbnails link
  • Colored the descriptions with a lighter gray than the current site style specifies
  • Changed the text-hover to underlined, to better align with styling for other text links on the page. Note: the style still doesn't match perfectly. Other links on the page apply a border-bottom, which misbehaved when i attempted in this context.

@jessicaschilling
Copy link
Contributor Author

@ericronne Thanks! These all LGTM. Sad to lose the stars, but you're correct on legibility, and since we're getting close to reworking this site as a whole, this as a fix seems fine. And good call on removing the hover for the caption text ... this made sense when the items were in boxes, but less so now.

@cwaring -- can you please have a look to hopefully bless this? Would be awesome to merge this Thursday. Thanks!

@ericronne ericronne self-requested a review November 15, 2019 16:38
@cwaring
Copy link
Contributor

cwaring commented Nov 15, 2019

I've checked this over and pushed a few tweaks to keep things tidy™ - please take a look and feel free to merge if you're happy.

@jessicaschilling
Copy link
Contributor Author

Thank you very much!

@jessicaschilling jessicaschilling merged commit eb4d278 into master Nov 15, 2019
@jessicaschilling jessicaschilling deleted the feat-implementations-to-install branch November 15, 2019 22:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Category: Content dif/easy Someone with a little familiarity can pick up size/medium Size: Medium topic/design-content Content design, writing, information architecture topic/design-front-end Front-end implementation of UX/UI work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants