Skip to content

Disable default hashes. #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 1, 2020
Merged

Disable default hashes. #73

merged 1 commit into from
Dec 1, 2020

Conversation

dvc94ch
Copy link
Contributor

@dvc94ch dvc94ch commented Dec 1, 2020 •
edited
Loading

@dvc94ch dvc94ch requested review from vmx and rklaehn December 1, 2020 14:43
rklaehn
rklaehn approved these changes Dec 1, 2020
View reviewed changes
Copy link
Contributor

@rklaehn rklaehn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So this means that you can use libipld core without all the hashes, and when you want hashes you need to specify them in your own multihash dependency? Looks reasonable. I will try it with the importer.

@dvc94ch
Copy link
Contributor Author

dvc94ch commented Dec 1, 2020

Yes that's the idea. You should also be able to use a custom table with exotic hashes.

@dvc94ch dvc94ch merged commit 3647ddc into ipld:master Dec 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rklaehn rklaehn rklaehn approved these changes

@vmx vmx Awaiting requested review from vmx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dvc94ch @rklaehn