Skip to content

add RetryBudget in DestinationRule #3512

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

add RetryBudget in DestinationRule #3512

wants to merge 1 commit into from

Conversation

zirain
Copy link
Member

@zirain zirain commented Jun 5, 2025

@zirain zirain requested a review from a team as a code owner June 5, 2025 12:36
@istio-testing istio-testing added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Jun 5, 2025
@zirain zirain added the release-notes-none Indicates a PR that does not require release notes. label Jun 5, 2025
ramaraochavali
ramaraochavali reviewed Jun 17, 2025
View reviewed changes
networking/v1alpha3/destination_rule.proto
// Specifies the minimum retry concurrency allowed for the retry budget.
// Defaults to 3.
//
uint32 min_retry_concurrency = 2;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So at any time, 3 concurrent retries are allowed even if retry budget is less than 3 based on request count? Is it used in low traffic scenarios? Can you expand more on when would user configure this?

ramaraochavali
ramaraochavali reviewed Jun 17, 2025
View reviewed changes
Copy link
Contributor

@ramaraochavali ramaraochavali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, one minor doc request

@istio/technical-oversight-committee Can you please take a look as well? Without this it is really hard to use retry budgets.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ramaraochavali ramaraochavali ramaraochavali left review comments

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
release-notes-none Indicates a PR that does not require release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zirain @ramaraochavali @istio-testing