remove cosine_distance/euclidean_distance impl #752
Conversation
in favor of usearch's.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #752 +/- ##
==========================================
- Coverage 87.51% 87.37% -0.15%
==========================================
Files 114 113 -1
Lines 10945 10920 -25
Branches 1501 1501
==========================================
- Hits 9579 9541 -38
- Misses 991 1000 +9
- Partials 375 379 +4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| @@ -217,23 +217,6 @@ def register_user_defined_sql_functions() -> None: | |||
| # Register optional functions if we have the necessary dependencies | |||
| # and otherwise register functions that will raise an exception with | |||
| # installation instructions | |||
| try: | |||
There was a problem hiding this comment.
from memory: we need this as a fallback because usearch is not available on Windows - unum-cloud/usearch#427
There was a problem hiding this comment.
There was a problem hiding this comment.
description on that PR should shed some light on the approach
|
@skshetry what is the status of this? |
1 similar comment
|
@skshetry what is the status of this? |
|
@skshetry is it still needed? |
Well, there are no extensions for macOS available atm (see unum-cloud/usearch#557). Linux is not working either for some reason, and |
so, do we need it or not? |
I created this to fix flaky tests. There are no flaky tests atm, we'll need this when unum-cloud/usearch#557 gets fixed. |
to do what? |
The |
in favor of usearch's.