feat: implements support for specifying depth order of drawing commands #33
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We use vg-renderer extensively in our project and have found the need to specify a depth order (which gets passed through to
bgfx::submit
asdepth
). This is used to, for example, render text on top of UI components or just layer different shapes in a specified orderingThis PR attempts to add a public API to vg-renderer to specify the depth ordering state of the renderer. I'm unsure about some things:
depthOrder
orsetDepthOrder
(I went with the former, opting for brevity)DrawCommand
, or is it sufficient to keep the depth order inState
? Again, I went with the formerDrawCommand
, then do we need tom_ForceNewDrawCommand
whenctxPopState
runs if the depth order is different?State
, then is it OK togetState(ctx)
from theend(...)
function in order to read the depthOrder forbgfx::submit
?I am happy to change anything (naming, etc) to match convention here