Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unplayed episode count and refresh number in real time #265

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

1hitsong
Copy link
Member

@1hitsong 1hitsong commented Apr 7, 2025

Changes

Consistently adds unplayed episode counts to TV Series and TV Seasons across the channel - libraries, series/season details, collections, search results, etc.

Refreshes the unplayed episode counts as data changes. For example, search for a TV series using the general search on the home screen. Click on the series and drill down to a single episode. Mark the episode watched. As you press the back button on your report, each screen's unplayed play count should update as your navigate back through the screens.

Additionally, using the item option menu will also update the unplayed count / played check mark display.

The disable unplayed count setting is honored.

Issues

Fixes #228

@1hitsong 1hitsong requested a review from jimdogx April 7, 2025 19:15
@1hitsong 1hitsong requested a review from a team as a code owner April 7, 2025 19:15
@1hitsong 1hitsong removed the request for review from a team April 7, 2025 19:15
@1hitsong 1hitsong changed the title Add unplayed episode counts and refresh in real time Add unplayed episode count and refresh number in real time Apr 7, 2025
@jimdogx
Copy link
Collaborator

jimdogx commented Apr 7, 2025

Found a corner case. Not sure if it's a legit case though.

  1. Enable "Rewatching Next Up" under Settings, User Interface, General
  2. Go to a show you've completed
  3. Mark one show unwatched
  4. Notice show on the Home Screen "Next Up" has a check and not the number "1"

@1hitsong
Copy link
Member Author

1hitsong commented Apr 8, 2025

How are you seeing a series in the Next Up section? Isn't it single episodes?

Can you post a screenshot? I'm having a hard time recreating the situation.

@jimdogx
Copy link
Collaborator

jimdogx commented Apr 8, 2025

How are you seeing a series in the Next Up section? Isn't it single episodes?

Can you post a screenshot? I'm having a hard time recreating the situation.

It is a single episode. But it has a checkmark. I'd expect nothing (like the rest of the items in Next Up) or a "1"

My guess is there is some logic that says "have you watched everything? put a checkmark". And by re-enabling "allow rewatched to show up in Next Up", you get the checkmark.

@1hitsong
Copy link
Member Author

1hitsong commented Apr 8, 2025

Does it show the checkmark on web?

The API returns a property for items called "played" and if it's true, the checkmark is displayed. I'm guessing since it's a "re-watch" the API is reporting is as played.

@jimdogx
Copy link
Collaborator

jimdogx commented Apr 8, 2025

Does it show the checkmark on web?

The API returns a property for items called "played" and if it's true, the checkmark is displayed. I'm guessing since it's a "re-watch" the API is reporting is as played.

Yep... I enabled Re-Watching on the web client and it does the same 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unplayed counts missing in new roku app, even when enabled
2 participants