[FIXED] JENKINS-60473 #235
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@oleg-nenashev Can you please review? |
|
CC @jenkinsci/code-reviewers |
|
Can you revert the formatting changes, to make the code review easier? |
|
I will do it tomorrow EOD. |
|
Hi @jetersen, I have reverted the formatting changes, also moved all new methods to bottom of each file. Let me know if anything required from my end. Thanks |
shimpossible
suggested changes
Sep 4, 2021
| @@ -61,6 +73,9 @@ public String run(@Nonnull EnvVars launchEnv, @Nonnull String image, @CheckForNu | |||
|
|
|||
| @Override | |||
| public List<String> listProcess(@Nonnull EnvVars launchEnv, @Nonnull String containerId) throws IOException, InterruptedException { | |||
| if (isContainerUnix) { | |||
| return listProcessUnixContainer(launchEnv, containerId); | |||
There was a problem hiding this comment.
Why not supper.listProcess(...) ? DockerClient.listProcess is already unix specific code. And include "-eo", "pid,comm" to remove the {} that busybox can put around the process names.
Closed
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just an attempt to improve #197
All credit goes to @mrsonicblue and @Bobby862
All I did optimized his code as he is away since 1 year (almost) and fixed java.io.NotSerializableException (his code was throwing this and even not properly running). Let me know what more to add or fix in this code.