Skip to content

Prompt for PIN on tpm-backed ssh keys #4018

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

oliverpool
Copy link

  • PR Description

Prompt for PIN on tpm-backed ssh keys.

Typical prompt:

Enter PIN for 'label':
  • Please check if the PR fulfills these requirements
  • Cheatsheets are up-to-date (run go generate ./...)
  • Code has been formatted (see here)
  • Tests have been added/updated (see here for the integration test guide)
  • You've read through your own file changes for silly mistakes etc

@oliverpool
Copy link
Author

I pushed this PR using this patch 😄

@oliverpool oliverpool mentioned this pull request Oct 31, 2024
6 tasks
@oliverpool
Copy link
Author

After downloading the patch, I adjusted my home-manager config to get it working with nix:

  programs.lazygit =
    let
      patchedPackage = pkgs.lazygit.overrideAttrs
        (finalAttrs: previousAttrs: {
          patches = [ ./assets/lazygit-4018.patch ];
        });
    in
    {
      enable = true;
      package = patchedPackage;
      settings = {...};
    };

(would be nicer if this PR could be merged, but in the meantime I get an updatable patched lazygit 🎉 )

Copy link
Owner

@jesseduffield jesseduffield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Could you squash your commits and rebase?

@oliverpool
Copy link
Author

oliverpool commented Mar 14, 2025

@jesseduffield squashed and rebased

@stefanhaller
Copy link
Collaborator

Also fixed by #4646, so closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants