Skip to content

Try handle unsolicited & clippy #184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 21, 2021
Merged

Conversation

mordak
Copy link
Contributor

@mordak mordak commented Mar 20, 2021

While working on handling unsolicited responses in the other branch, bumped into these:

  • Rename handle_unilateral to try_handle_unilateral because suggested here.
  • Make clippy happy.

This change is Reviewable

mordak added 2 commits March 20, 2021 14:21
More accurately conveys that the function might not actually handle it.
@codecov
Copy link

codecov bot commented Mar 20, 2021

Codecov Report

Merging #184 (d0e61c7) into master (bd0a045) will increase coverage by 0.09%.
The diff coverage is 56.25%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #184      +/-   ##
==========================================
+ Coverage   77.15%   77.24%   +0.09%     
==========================================
  Files          13       13              
  Lines        1593     1591       -2     
==========================================
  Hits         1229     1229              
+ Misses        364      362       -2     
Impacted Files Coverage Δ
src/extensions/metadata.rs 60.00% <37.50%> (+1.46%) ⬆️
src/parse.rs 87.03% <66.66%> (ø)
src/client.rs 84.75% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bd0a045...d0e61c7. Read the comment docs.

Copy link
Owner

@jonhoo jonhoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great change, thanks!

@jonhoo jonhoo merged commit 39a78fd into jonhoo:master Mar 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants