[6.0] Run Task #45313
Open
[6.0] Run Task #45313
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was pointed out in joomla#36453 that "Run Test" was probably not the best wording to use as you could be using it to simply run a task manually that is never scheduled This PR changes the language to Task instead of test for the button and the modal. joomla#36453 identified other issues and this PR does not attempt to address them. There is another PR joomla#36725 that also addresses this but in a much more complex means and appears to be abandoned
|
|
|
That was intentional. The column is still test task but the button is run task |
|
It is a manual run and not a simulated test run. See comment from #44356
|
|
What would you suggest as the column title then |
|
|
|
Updated column title and permissions label |
|
I have tested this item ✅ successfully on 7c02637 This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45313. |
|
I have tested this item ✅ successfully on 7c02637 Thanks @brianteeman This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45313. |
|
RTC This comment was created with the J!Tracker Application at issues.joomla.org/tracker/joomla-cms/45313. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was pointed out in #36453 that "Run Test" was probably not the best wording to use as you could be using it to simply run a task manually that is never scheduled
This PR changes the language to Task instead of test for the button and the modal.
#36453 identified other issues and this PR does not attempt to address them.
There is another PR #36725 that also addresses this but in a much more complex means and appears to be abandoned. imho it is over-engineered and this simpler solution will suffice
Actual result BEFORE applying this Pull Request
Expected result AFTER applying this Pull Request
Link to documentations
Please select:
Documentation link for docs.joomla.org:
No documentation changes for docs.joomla.org needed
Pull Request link for manual.joomla.org:
No documentation changes for manual.joomla.org needed