forked from bitcoin/bitcoin
-
Notifications
You must be signed in to change notification settings - Fork 1
2025 implement bip352 receiving #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
Eunovo
wants to merge
17
commits into
josibake:implement-bip352-sending
Choose a base branch
from
Eunovo:2025-implement-bip352-receiving
base: implement-bip352-sending
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
2025 implement bip352 receiving #8
Eunovo
wants to merge
17
commits into
josibake:implement-bip352-sending
from
Eunovo:2025-implement-bip352-receiving
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0cd11a3
to
3b1c0df
Compare
This method makes it easier to tweak silent payment spend keys in later commits
SilentPaymentDSPKM needs spent_coins to scan transaction for payments. The spent_coins data is available in mempool cache and on disk. We: - Include spent_coins fetched from Mempool cache in TransactionAddedToMempool notification - Fetch block undo data from disk in blockConnected to extract spent_coins
…ss and getrawchangeaddress
Support sp addresses and scriptPubKeys generated from sp addresses.
3b1c0df
to
eefcc1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.