Skip to content

OpenAPI: Fix "id" parameter in URL to be string #1438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 14, 2024

Conversation

bkoelman
Copy link
Member

This PR corrects the "id" parameter type to be string in the JSON:API request URL.

Contributes to #1051:

Also address the following: When using Identifiable where TId is other than string, eg int, the generated client will have its id parameter typed as int in methods, which is incorrect: it should always be string.

QUALITY CHECKLIST

Copy link

codecov bot commented Jan 14, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (fda2b36) 91.09% compared to head (b0fa688) 91.08%.

Files Patch % Lines
...penApi/SwaggerComponents/JsonApiSchemaGenerator.cs 87.50% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           openapi    #1438      +/-   ##
===========================================
- Coverage    91.09%   91.08%   -0.02%     
===========================================
  Files          384      384              
  Lines        12357    12358       +1     
  Branches      1987     1989       +2     
===========================================
- Hits         11257    11256       -1     
  Misses         710      710              
- Partials       390      392       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bkoelman bkoelman marked this pull request as ready for review January 14, 2024 12:42
@bkoelman bkoelman merged commit 37f41fe into openapi Jan 14, 2024
@bkoelman bkoelman deleted the openapi-fix-id-parameter-type branch January 14, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant