Skip to content

Fix for PR1386 #1401

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jun 28, 2025
Merged

Fix for PR1386 #1401

merged 13 commits into from
Jun 28, 2025

Conversation

loiclefevre
Copy link
Contributor

@loiclefevre loiclefevre commented Feb 7, 2025

As requested by @gregsdennis, this PR fixes the Oracle case study (PR1386) to leverage fixed blog-styled components.

@loiclefevre loiclefevre requested a review from a team as a code owner February 7, 2025 08:22
@loiclefevre loiclefevre mentioned this pull request Feb 7, 2025
Copy link

github-actions bot commented Feb 7, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview 14876e0

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (6d33bec) to head (14876e0).
Report is 77 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1401   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        10           
  Lines          396       396           
  Branches       106       106           
=========================================
  Hits           396       396           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@benjagm
Copy link
Collaborator

benjagm commented Feb 8, 2025

Hi! Thanks a lot for this amazing case study. We merged the other PR, but before moving forward with this one, we need to rebase this to get the last changes.

@benjagm benjagm requested a review from gregsdennis March 4, 2025 08:29
Copy link
Collaborator

@benjagm benjagm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks Loic!

@gregsdennis
Copy link
Member

This PR requires the fixes described in this comment.

I don't think these have been addressed yet.

@benjagm benjagm moved this to In Review Team in PR - Triage Group Mar 5, 2025
@benjagm
Copy link
Collaborator

benjagm commented Jun 27, 2025

Hi Greg. @Utkarsh-123github have been reviewing the PR and it seems all the changes are already in production. Can you confirm if you are still missing something?

@benjagm
Copy link
Collaborator

benjagm commented Jun 28, 2025

Hi everyone we proceed with merging this PR as all the comments have been addressed. Thanks a lot for your patience @loiclefevre

@benjagm benjagm merged commit 9777f3c into json-schema-org:main Jun 28, 2025
9 checks passed
@github-project-automation github-project-automation bot moved this from In Review Team to Done in PR - Triage Group Jun 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants