-
-
Notifications
You must be signed in to change notification settings - Fork 281
Fix for PR1386 #1401
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for PR1386 #1401
Conversation
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1401 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 10 10
Lines 396 396
Branches 106 106
=========================================
Hits 396 396 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hi! Thanks a lot for this amazing case study. We merged the other PR, but before moving forward with this one, we need to rebase this to get the last changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks Loic!
This PR requires the fixes described in this comment. I don't think these have been addressed yet. |
Hi Greg. @Utkarsh-123github have been reviewing the PR and it seems all the changes are already in production. Can you confirm if you are still missing something? |
Hi everyone we proceed with merging this PR as all the comments have been addressed. Thanks a lot for your patience @loiclefevre |
As requested by @gregsdennis, this PR fixes the Oracle case study (PR1386) to leverage fixed blog-styled components.