Skip to content

Adapt Checkbox & SearchBar to ShadCN, Add Tests, and Fix Tools Filter position #1686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

idanidan29
Copy link
Contributor

What kind of change does this PR introduce?

  • Adapts two components to the ShadCN library:
    • Checkbox component (improved with fill states, a hover effect, and proper containment)
    • SearchBar component (migrated without visual changes)
  • Creates and adjusts Cypress test files for both components to ensure reliability and behavior coverage.
  • Fixes issue ✨ Enhancement: Make the Side Panel Fixed on the Tooling Page #1279 by making the Tools filter sidebar fixed to the side of the viewport.

Issue Number:

Screenshots/videos:

  • Checkbox component before adjustment:
    Checkbox before

  • Checkbox component after adjustment:
    Checkbox after

The SearchBar component looks exactly the same after migration to ShadCN.

Summary

This PR:

  • Migrates the existing Checkbox component to the ShadCN library.
    • Enhances styling with fill states, a hover effect, and proper containment.
  • Migrates the SearchBar component to ShadCN (visual appearance unchanged).
  • Adds and adjusts Cypress tests for both components to ensure reliability and behavior coverage.
  • Fixes issue ✨ Enhancement: Make the Side Panel Fixed on the Tooling Page #1279 by making the Tools filter sidebar fixed to the side of the viewport, improving usability.

Does this PR introduce a breaking change?

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.

@idanidan29 idanidan29 requested a review from a team as a code owner June 3, 2025 16:47
Copy link

github-actions bot commented Jun 3, 2025

built with Refined Cloudflare Pages Action

⚡ Cloudflare Pages Deployment

Name Status Preview Last Commit
website ✅ Ready (View Log) Visit Preview 540ecde

@idanidan29 idanidan29 changed the title Phase 1.1 Adapt Checkbox & SearchBar to ShadCN, Add Tests, and Fix Tools Filter position Jun 3, 2025
Copy link

codecov bot commented Jun 3, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (169a524) to head (540ecde).

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #1686   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           10        14    +4     
  Lines          396       410   +14     
  Branches       106       106           
=========================================
+ Hits           396       410   +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready to review
Development

Successfully merging this pull request may close these issues.

✨ Enhancement: Make the Side Panel Fixed on the Tooling Page
1 participant