Fix use of norm and remove vecnorm #242
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ararslan
force-pushed
the
aa/no-vecnorm
branch
2 times, most recently
from
ac19049 to
5dbd45d
Compare
matbesancon
reviewed
Nov 6, 2018
jrevels
reviewed
Nov 6, 2018
ararslan
force-pushed
the
aa/no-vecnorm
branch
from
5dbd45d to
72822d0
Compare
jrevels
reviewed
Nov 6, 2018
The behavior of `norm(x, p)` for matrices changed in Julia PR 27401 to be the same as `norm(vec(x), p)` and `vecnorm` was removed. The previous behavior of `norm` for matrices is now captured by `opnorm`. This updates our extensions to these functions to match, and emits deprecation warnings as appropriate. As a somewhat related change, this also deprecates the positional dimension argument to `sum` in favor of keyword arguments, in keeping with Base.
opnorm will create OperatorNormAtom objects directly for p=2.
ararslan
force-pushed
the
aa/no-vecnorm
branch
from
72822d0 to
27595b0
Compare
iamed2
approved these changes
Nov 6, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The behavior of
norm(x, p)for matrices changed in JuliaLang/julia#27401 to be the same asnorm(vec(x), p)andvecnormwas removed. The previous behavior ofnormfor matrices is now captured byopnorm. This updates our extensions to these functions to match, and emits deprecation warnings as appropriate.As a somewhat related change, this also deprecates the positional dimension argument to
sumin favor of keyword arguments, in keeping with Base.Properly fixes #231, which was already closed, and should fix an error in SchattenNorms observed with JuliaCIBot (see here).