Skip to content

Improve type inference in Utilities #1316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 5, 2021
Merged

Improve type inference in Utilities #1316

merged 4 commits into from
May 5, 2021

Conversation

odow
Copy link
Member

@odow odow commented May 5, 2021

Part of #1313

This was stopping the delete from precompiling:

After

Running: clp 
 18.562974 seconds (38.47 M allocations: 2.200 GiB, 5.93% gc time, 43.03% compilation time)
  0.001416 seconds (5.95 k allocations: 534.227 KiB)
Running: clp --no-bridge
 10.577259 seconds (18.82 M allocations: 1.070 GiB, 5.15% gc time, 96.09% compilation time)
  0.001221 seconds (3.01 k allocations: 309.070 KiB)
Running: glpk 
 14.450203 seconds (33.37 M allocations: 1.910 GiB, 6.87% gc time, 53.09% compilation time)
  0.000738 seconds (3.17 k allocations: 249.656 KiB)
Running: glpk --no-bridge
 11.603105 seconds (20.37 M allocations: 1.163 GiB, 5.11% gc time, 99.98% compilation time)
  0.000591 seconds (2.52 k allocations: 233.828 KiB)

image

Copy link
Member

@blegat blegat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! You're getting good at this

@odow
Copy link
Member Author

odow commented May 5, 2021

Not good enough to get the tests to pass... the 30 minute test time for MOI is a drag.

@odow odow merged commit 7d51687 into master May 5, 2021
@odow odow deleted the od/inference branch May 5, 2021 20:09
@blegat blegat added this to the v0.10 milestone May 22, 2021
blegat pushed a commit that referenced this pull request May 22, 2021
blegat pushed a commit that referenced this pull request May 22, 2021
@blegat blegat modified the milestones: v0.10, v0.9.22 May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants