Skip to content

Refactor filenames and move some code around #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

odow
Copy link
Member

@odow odow commented May 28, 2025

I should probably split this up, but let me comment in-line

return Interval(a.lo * x, a.hi * x)
end
return Interval(a.hi * x, a.lo * x)
end
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's questionable that a very simple type like this and a few methods need a license attribution. Since both packages are MIT, we're in the clear, so I just moved into this file.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I moved the files into the main one in MathOptConflict/Infeasibility/InfeasibleSubsystem, so I will not rush this part here for now

for t in f.terms
out += _eval_variables(value_fn, t)
end
return out
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditto here: why is this _eval_variales needed?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because MOI assumes the output type is the same as the ScalarAffineFunction (Float64), but we need the output to be an interval. JuMP does is correctly: #19 (comment)

@joaquimg
Copy link
Member

I was thining about code organization.

The printing stuff is very verbose so I was considering splitting the analysis files in two:

  • algorithm.jl
  • printing.jl
    (names open to bikeshed)
    So the structure could also be:
src
  ModelAnalyzer.jl
  Numerical
    algorithm.jl
    printing.jl
...

@joaquimg joaquimg mentioned this pull request May 29, 2025
@joaquimg joaquimg mentioned this pull request Jun 20, 2025
@joaquimg
Copy link
Member

replaced by #40

@joaquimg joaquimg closed this Jun 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants