Try switching from rustacuda to cust #23
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It may be interesting to look into https://github.com/coreylowman/cudarc |
|
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #23 +/- ##
==========================================
- Coverage 33.38% 33.32% -0.07%
==========================================
Files 53 53
Lines 6653 6650 -3
==========================================
- Hits 2221 2216 -5
- Misses 4432 4434 +2 ☔ View full report in Codecov by Sentry. |
|
While the need for a |
juntyr
commented
Feb 11, 2025
| &[ModuleJitOption::OptLevel(OptLevel::O4)], | ||
| )?); | ||
|
|
||
| // FIXME: cust's Module::get_function takes a str and turns it back into |
There was a problem hiding this comment.
This might still be nice to fix upstream
juntyr
commented
Feb 11, 2025
| } | ||
|
|
||
| unsafe impl DeviceCopy for _ArcInnerHeader {} | ||
| #[cfg(feature = "host")] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rustacudais no longer maintained, and includes all ofrustacudaand most of the custom patches we are using inrust-cuda.However, the following incompatibilities remain:
cust_core::DeviceCopynow hasCopyas a supertrait. This is both too weak and too strong forrust-cuda. There is no workaround. Ifcustdoesn't change this requirement, no migration can occur.DeviceCopyshould not requireCopyRust-GPU/Rust-CUDA#124custto explore a better designStream::wait_eventtakes an ownedEventandEvents cannot be cloned or inspected. This could be fixed by falling back to raw FFI for all usages. wait_event method in Stream Rust-GPU/Rust-CUDA#110Stream::add_callbackno longer provides access to the current stream status. The callback might just not be scheduled anymore if an error occurred (which could result in a never-resolving async future), or do something even worse. This could be fixed by falling back to raw FFI. https://stackoverflow.com/questions/56448390/how-to-recover-from-cuda-errors-when-using-cudalaunchhostfunc-instead-of-cudastr