-
Notifications
You must be signed in to change notification settings - Fork 345
[feat/1316] Support Serving Metrics On an Alternate Port #1529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
divyabiyani
wants to merge
26
commits into
jupyter-server:main
Choose a base branch
from
divyabiyani:1316
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature Request: Jupyter Server Issue #1316 —
Support Serving Metrics On an Alternate Port
Label suggestion:
enhancement
Summary Of Changes:
9090
.--ServerApp.metrics_port=<port>
argument. Setting--ServerApp.metrics_port=0
will disable the separate server and serve metrics through the main Tornado server.--ServerApp.authenticate_prometheus=<bool>
— Enables authentication for metrics endpoint if set totrue
.--ServerApp.record_http_request_metrics=<bool>
— Enables or disables recording of HTTP request metrics.Test Scenarios Verified:
ServerApp.token=''
or--ServerApp.password=''
is provided:--ServerApp.authenticate_prometheus=False
.--ServerApp.authenticate_prometheus=True
.ServerApp.token
andServerApp.password
are provided.--ServerApp.record_http_request_metrics=True
.Verified metrics served with
![Uploading Screenshot 2025-06-15 at 7.34.03 PM.png…]()
--ServerApp.metrics_port=9009
.Verified fallback behavior with
![Uploading Screenshot 2025-06-15 at 7.33.44 PM.png…]()
--ServerApp.metrics_port=0
(metrics served on main Tornado server).Verified that when the configured metrics port is already in use, server startup fails with appropriate error.
![Uploading Screenshot 2025-06-15 at 11.24.08 PM.png…]()