Skip to content

Fix for issue #7565 on Click to add a cell button not in background #7587

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+7 −2
Open

Fix for issue #7565 on Click to add a cell button not in background #7587

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions packages/notebook-extension/style/base.css
View file
Original file line number Diff line number Diff line change
@@ -116,9 +116,14 @@ body[data-notebook='notebooks']

/* Tweak the notebook footer (to add a new cell) */
body[data-notebook='notebooks'] .jp-Notebook-footer {
background: unset;
background: var(--jp-layout-color1);
margin-left: auto !important;
margin-right: auto !important;
border-top: 1px solid var(--jp-border-color1);
width: 100%;
margin-left: unset;
border: 1px solid var(--jp-border-color1) !important;
border-radius: 4px;
opacity: 1;
}

/* Mobile View */

Unchanged files with check annotations Beta

View file
ui-tests/test/mobile.spec.ts
// Copyright (c) Jupyter Development Team.
// Distributed under the terms of the Modified BSD License.
import { IJupyterLabPage, expect, galata } from '@jupyterlab/galata';

Check warning on line 4 in ui-tests/test/mobile.spec.ts

GitHub Actions / Test Lint 

'IJupyterLabPage' is defined but never used
import { test } from './fixtures';
await hideAddCellButton(notebook);
}
expect(await notebook.screenshot()).toMatchSnapshot('notebook.png');

Check failure on line 73 in ui-tests/test/mobile.spec.ts

GitHub Actions / ui-tests (chromium)

[chromium] › test/mobile.spec.ts:43:7 › Mobile › The layout should be more compact on the notebook page 

  2) [chromium] › test/mobile.spec.ts:43:7 › Mobile › The layout should be more compact on the notebook page 
    Error: expect(Buffer).toMatchSnapshot(expected)

      1135 pixels (ratio 0.01 of all image pixels) are different.

    Expected: /home/runner/work/notebook/notebook/ui-tests/test/mobile.spec.ts-snapshots/notebook-chromium-linux.png
    Received: /home/runner/work/notebook/notebook/ui-tests/test-results/test-mobile-Mobile-The-lay-36afb-ompact-on-the-notebook-page-chromium/notebook-actual.png
        Diff: /home/runner/work/notebook/notebook/ui-tests/test-results/test-mobile-Mobile-The-lay-36afb-ompact-on-the-notebook-page-chromium/notebook-diff.png


      71 |     }
      72 |
    > 73 |     expect(await notebook.screenshot()).toMatchSnapshot('notebook.png');
         |                                         ^
      74 |     await notebook.close();
      75 |   });
      76 | });
        at /home/runner/work/notebook/notebook/ui-tests/test/mobile.spec.ts:73:41

Check failure on line 73 in ui-tests/test/mobile.spec.ts

GitHub Actions / ui-tests (chromium)

[chromium] › test/mobile.spec.ts:43:7 › Mobile › The layout should be more compact on the notebook page 

  2) [chromium] › test/mobile.spec.ts:43:7 › Mobile › The layout should be more compact on the notebook page 

    Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
    Error: expect(Buffer).toMatchSnapshot(expected)

      1135 pixels (ratio 0.01 of all image pixels) are different.

    Expected: /home/runner/work/notebook/notebook/ui-tests/test/mobile.spec.ts-snapshots/notebook-chromium-linux.png
    Received: /home/runner/work/notebook/notebook/ui-tests/test-results/test-mobile-Mobile-The-lay-36afb-ompact-on-the-notebook-page-chromium-retry1/notebook-actual.png
        Diff: /home/runner/work/notebook/notebook/ui-tests/test-results/test-mobile-Mobile-The-lay-36afb-ompact-on-the-notebook-page-chromium-retry1/notebook-diff.png


      71 |     }
      72 |
    > 73 |     expect(await notebook.screenshot()).toMatchSnapshot('notebook.png');
         |                                         ^
      74 |     await notebook.close();
      75 |   });
      76 | });
        at /home/runner/work/notebook/notebook/ui-tests/test/mobile.spec.ts:73:41
await notebook.close();
});
});
View file
ui-tests/test/filebrowser.spec.ts
const toolbar = page.getByRole('toolbar');
['Rename', 'Delete', 'Open', 'Download', 'Delete'].forEach(async (text) => {
expect(toolbar.getByText(text)).toBeVisible();

Check failure on line 41 in ui-tests/test/filebrowser.spec.ts

GitHub Actions / ui-tests (firefox)

[firefox] › test/filebrowser.spec.ts:32:7 › File Browser › Select one file 

  1) [firefox] › test/filebrowser.spec.ts:32:7 › File Browser › Select one file ────────────────────
    Error: expect(locator).toBeVisible()

    Locator: getByRole('toolbar').getByText('Open')
    Expected: visible
    Received: hidden
    Call log:
      - expect.toBeVisible with timeout 5000ms
      - waiting for getByRole('toolbar').getByText('Open')


      39 |
      40 |     ['Rename', 'Delete', 'Open', 'Download', 'Delete'].forEach(async (text) => {
    > 41 |       expect(toolbar.getByText(text)).toBeVisible();
         |                                       ^
      42 |     });
      43 |   });
      44 |
        at forEach (/home/runner/work/notebook/notebook/ui-tests/test/filebrowser.spec.ts:41:39)
        at /home/runner/work/notebook/notebook/ui-tests/test/filebrowser.spec.ts:40:56
});
});
View file
ui-tests/test/general.spec.ts
// wait for the notebook to be ready
await waitForNotebook(page, browserName);
expect(await page.screenshot()).toMatchSnapshot('notebook.png');

Check failure on line 35 in ui-tests/test/general.spec.ts

GitHub Actions / ui-tests (chromium)

[chromium] › test/general.spec.ts:13:7 › General › The notebook should render 

  1) [chromium] › test/general.spec.ts:13:7 › General › The notebook should render ─────────────────
    Error: expect(Buffer).toMatchSnapshot(expected)

      2507 pixels (ratio 0.01 of all image pixels) are different.

    Expected: /home/runner/work/notebook/notebook/ui-tests/test/general.spec.ts-snapshots/notebook-chromium-linux.png
    Received: /home/runner/work/notebook/notebook/ui-tests/test-results/test-general-General-The-notebook-should-render-chromium/notebook-actual.png
        Diff: /home/runner/work/notebook/notebook/ui-tests/test-results/test-general-General-The-notebook-should-render-chromium/notebook-diff.png


      33 |     await waitForNotebook(page, browserName);
      34 |
    > 35 |     expect(await page.screenshot()).toMatchSnapshot('notebook.png');
         |                                     ^
      36 |   });
      37 | });
      38 |
        at /home/runner/work/notebook/notebook/ui-tests/test/general.spec.ts:35:37

Check failure on line 35 in ui-tests/test/general.spec.ts

GitHub Actions / ui-tests (chromium)

[chromium] › test/general.spec.ts:13:7 › General › The notebook should render 

  1) [chromium] › test/general.spec.ts:13:7 › General › The notebook should render ─────────────────

    Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
    Error: expect(Buffer).toMatchSnapshot(expected)

      2507 pixels (ratio 0.01 of all image pixels) are different.

    Expected: /home/runner/work/notebook/notebook/ui-tests/test/general.spec.ts-snapshots/notebook-chromium-linux.png
    Received: /home/runner/work/notebook/notebook/ui-tests/test-results/test-general-General-The-notebook-should-render-chromium-retry1/notebook-actual.png
        Diff: /home/runner/work/notebook/notebook/ui-tests/test-results/test-general-General-The-notebook-should-render-chromium-retry1/notebook-diff.png


      33 |     await waitForNotebook(page, browserName);
      34 |
    > 35 |     expect(await page.screenshot()).toMatchSnapshot('notebook.png');
         |                                     ^
      36 |   });
      37 | });
      38 |
        at /home/runner/work/notebook/notebook/ui-tests/test/general.spec.ts:35:37
});
});
View file
ui-tests/test/notebook.spec.ts
// wait for the notebook to be ready
await waitForNotebook(page, browserName);
expect(await page.screenshot()).toMatchSnapshot('notebook-full-width.png');

Check failure on line 203 in ui-tests/test/notebook.spec.ts

GitHub Actions / ui-tests (chromium)

[chromium] › test/notebook.spec.ts:179:7 › Notebook › Toggle the full width of the notebook 

  3) [chromium] › test/notebook.spec.ts:179:7 › Notebook › Toggle the full width of the notebook ───
    Error: expect(Buffer).toMatchSnapshot(expected)

      2647 pixels (ratio 0.01 of all image pixels) are different.

    Expected: /home/runner/work/notebook/notebook/ui-tests/test/notebook.spec.ts-snapshots/notebook-full-width-chromium-linux.png
    Received: /home/runner/work/notebook/notebook/ui-tests/test-results/test-notebook-Notebook-Toggle-the-full-width-of-the-notebook-chromium/notebook-full-width-actual.png
        Diff: /home/runner/work/notebook/notebook/ui-tests/test-results/test-notebook-Notebook-Toggle-the-full-width-of-the-notebook-chromium/notebook-full-width-diff.png


      201 |     await waitForNotebook(page, browserName);
      202 |
    > 203 |     expect(await page.screenshot()).toMatchSnapshot('notebook-full-width.png');
          |                                     ^
      204 |
      205 |     // undo the full width
      206 |     await page.menu.clickMenuItem(menuPath);
        at /home/runner/work/notebook/notebook/ui-tests/test/notebook.spec.ts:203:37

Check failure on line 203 in ui-tests/test/notebook.spec.ts

GitHub Actions / ui-tests (chromium)

[chromium] › test/notebook.spec.ts:179:7 › Notebook › Toggle the full width of the notebook 

  3) [chromium] › test/notebook.spec.ts:179:7 › Notebook › Toggle the full width of the notebook ───

    Retry #1 ───────────────────────────────────────────────────────────────────────────────────────
    Error: expect(Buffer).toMatchSnapshot(expected)

      2647 pixels (ratio 0.01 of all image pixels) are different.

    Expected: /home/runner/work/notebook/notebook/ui-tests/test/notebook.spec.ts-snapshots/notebook-full-width-chromium-linux.png
    Received: /home/runner/work/notebook/notebook/ui-tests/test-results/test-notebook-Notebook-Toggle-the-full-width-of-the-notebook-chromium-retry1/notebook-full-width-actual.png
        Diff: /home/runner/work/notebook/notebook/ui-tests/test-results/test-notebook-Notebook-Toggle-the-full-width-of-the-notebook-chromium-retry1/notebook-full-width-diff.png


      201 |     await waitForNotebook(page, browserName);
      202 |
    > 203 |     expect(await page.screenshot()).toMatchSnapshot('notebook-full-width.png');
          |                                     ^
      204 |
      205 |     // undo the full width
      206 |     await page.menu.clickMenuItem(menuPath);
        at /home/runner/work/notebook/notebook/ui-tests/test/notebook.spec.ts:203:37
// undo the full width
await page.menu.clickMenuItem(menuPath);
View file
ui-tests/test/links.spec.ts

Check failure on line 1 in ui-tests/test/links.spec.ts

GitHub Actions / ui-tests (chromium)

[chromium] › test/links.spec.ts:21:7 › Local Links › Open the current directory 

  4) [chromium] › test/links.spec.ts:21:7 › Local Links › Open the current directory ───────────────
    Test timeout of 60000ms exceeded.

Check failure on line 25 in ui-tests/test/links.spec.ts

GitHub Actions / ui-tests (chromium)

[chromium] › test/links.spec.ts:21:7 › Local Links › Open the current directory 

  4) [chromium] › test/links.spec.ts:21:7 › Local Links › Open the current directory ───────────────
    Error: proxy.waitForEvent: Test timeout of 60000ms exceeded.
    =========================== logs ===========================
    waiting for event "popup"
    ============================================================

      23 |
      24 |     const [current] = await Promise.all([
    > 25 |       page.waitForEvent('popup'),
         |            ^
      26 |       page.getByText('Current Directory').last().click(),
      27 |     ]);
      28 |
        at /home/runner/work/notebook/notebook/ui-tests/test/links.spec.ts:25:12