FE: Closes #535, allowing to configure cors through spring properties #574
Conversation
kapybro
bot
added
status/triage
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hi aditya-baldwa! 👋
Welcome, and thank you for opening your first PR in the repo!
Please wait for triaging by our maintainers.
Please take a look at our contributing guide.
Haarolean
added
the
hacktoberfest-accepted
aditya-baldwa
force-pushed
the
feat/535
branch
from
23828bd to
cbc8743
Compare
# Conflicts: # api/src/main/java/io/kafbat/ui/config/CorsGlobalConfiguration.java # api/src/main/java/io/kafbat/ui/config/CorsProperties.java # api/src/main/resources/application.yml
| allowed-origins: "*" | ||
| allowed-methods: "GET, PUT, POST, DELETE, OPTIONS" | ||
| allowed-headers: "Content-Type" | ||
| allow-credentials: "true" |
There was a problem hiding this comment.
* for allow-origin can not be used simultaneously with allow-credentials set to true. I suggest keeping the configuration as it is right now for backward compatibility and using the new approach if either of the properties (cors.*) is set (not null) or introducing even a new properly like (cors.enabled). What do you think?
There was a problem hiding this comment.
I think allowed-origins should be null by default and if it is null we could pass request.getHeaders().getOrigin(). This will keep backward compatibility.
There was a problem hiding this comment.
@aditya-baldwa hi, could you address this please?
There was a problem hiding this comment.
Hi @Haarolean, yes, will check on it
What changes did you make? (Give an overview)
Resoves #535
Is there anything you'd like reviewers to focus on?
How Has This Been Tested? (put an "x" (case-sensitive!) next to an item)
Checklist (put an "x" (case-sensitive!) next to all the items, otherwise the build will fail)
Check out Contributing and Code of Conduct
A picture of a cute animal (not mandatory but encouraged)
