Skip to content

Patches file patch #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Patches file patch #91

wants to merge 1 commit into from

Conversation

enotick
Copy link

@enotick enotick commented Apr 1, 2021

@mikemccaffrey we use patches file on a lot of our projects and it seems that it keeps composer.json cleaner. Please review, I think it would be nice to add.

@enotick enotick requested a review from mikemccaffrey April 1, 2021 17:02
@mikemccaffrey
Copy link

I would worry about this implementation, since it seems like it would make patches less obvious. We want to make sure people see and review the patches every time the go to update the modules on the site in order to see if they are still needed.

@enotick
Copy link
Author

enotick commented May 22, 2021

I would worry about this implementation, since it seems like it would make patches less obvious. We want to make sure people see and review the patches every time the go to update the modules on the site in order to see if they are still needed.

Most of our projects already use it, they were setup before me joining and this is considered the way to go in the community. Composer will tell you if the patch isn't needed anymore during every update, it doesn't matter where the patches are listed. It makes composer.json cleaner and easier to read.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants