Skip to content

[LFX-pretest]: Implemented local git command to support downloading from the bare repo #418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 1, 2024

Conversation

Gmin2
Copy link
Contributor

@Gmin2 Gmin2 commented Jul 30, 2024

1. Does this PR affect any open issues?(Y/N) and add issue references

  • N
  • Y

Related to #384

2. What is the scope of this PR (e.g. component or file name):

pkg/git/git.go
pkg/git/git_test.go

3. Provide a description of the PR(e.g. more details, effects, motivations or doc link):

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Other

4. Are there any breaking changes?(Y/N) and describe the breaking changes(e.g. more details, motivations or doc link):

implemented local git command to support downloading from the bare repository, and updated the cloneBare method to be private

  • N
  • Y

5. Are there test cases for these changes?(Y/N) select and add more details, references or doc links:

  • Unit test
  • Integration test
  • Benchmark (add benchmark stats below)
  • Manual test (add detailed scripts or steps below)
  • Other

Screenshot from 2024-07-30 17-24-37
Screenshot from 2024-07-30 17-24-37

added specific test for cloneBare and checkoutCloneBare method

@Gmin2
Copy link
Contributor Author

Gmin2 commented Jul 30, 2024

Can i get a review
cc @zong-zhe

@coveralls
Copy link

coveralls commented Jul 30, 2024

Pull Request Test Coverage Report for Build 10164463163

Details

  • 37 of 49 (75.51%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.4%) to 40.261%

Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/git/git.go 37 49 75.51%
Files with Coverage Reduction New Missed Lines %
pkg/git/git.go 1 55.4%
Totals Coverage Status
Change from base Build 10162428116: 0.4%
Covered Lines: 3121
Relevant Lines: 7752

💛 - Coveralls

Signed-off-by: utnim2 <[email protected]>
@Peefy Peefy merged commit ad11f97 into kcl-lang:main Aug 1, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants