feat: support OCI index with duplicate filenames by deduplicatin… #632
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…g pulled files - Add \dedupePulledFiles\ helper in oci/oci.go to rename colliding files in a pull directory - Invoke \DedupePulledFiles\ after each OCI pull in downloader/downloader.go - Ensures multiple KCL packages with the same basename (e.g. main.k) do not overwrite one another Signed-off-by: asmit27rai <[email protected]>
|
@zong-zhe Pls review this PR |
Pull Request Test Coverage Report for Build 14845947371Details
💛 - Coveralls |
|
Hi @asmit27rai 😄 Is this pr still going on? If you want to merge this PR, it needs more test cases |
zong-zhe
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR resolves #363 by allowing an OCI artifact index containing multiple blobs with the same filename (e.g.
main.k) to be pulled without collisions. Previously, the pull would overwrite earlier files, making some packages inaccessible.Fixes: #363