Skip to content

fix: disappearing workflow inputs in UI builder #4748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 11, 2025

Conversation

Kiryous
Copy link
Contributor

@Kiryous Kiryous commented May 8, 2025

Closes #4747

Before

Screen.Recording.2025-05-08.at.22.12.45.mov
Screenshot 2025-05-08 at 22 53 59

After

Screen.Recording.2025-05-08.at.22.51.50.mov
Screenshot 2025-05-08 at 22 54 20

Copy link

vercel bot commented May 8, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
keep ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 11, 2025 8:19am

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. Bug Something isn't working UI User interface related issues labels May 8, 2025
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels May 8, 2025
shahargl
shahargl previously approved these changes May 8, 2025
Copy link
Member

@shahargl shahargl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label May 8, 2025
@Kiryous
Copy link
Contributor Author

Kiryous commented May 9, 2025

@greptileai

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Summary

This PR implements a comprehensive fix for workflow inputs persistence in the UI builder by enhancing the parsing and schema validation logic.

  • Added WorkflowInputSchema in /keep-ui/entities/workflows/model/schema.ts to properly validate input properties including name, type, and visual requirements
  • Updated /keep-ui/entities/workflows/lib/parser.ts to handle input extraction and enhancement with proper null checks
  • Added test coverage in /keep-ui/entities/workflows/lib/__tests__/parser.test.ts with new workflowWithInputs test fixture
  • Modified field ordering in /keep-ui/entities/workflows/lib/yaml-utils.ts to maintain consistent workflow input positions
  • Consolidated workflow definition schemas by deprecating YamlProvider interface in favor of YamlWorkflowDefinition

6 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile

Copy link

codecov bot commented May 10, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.03%. Comparing base (61be570) to head (6ced33f).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4748   +/-   ##
=======================================
  Coverage   31.03%   31.03%           
=======================================
  Files          93       93           
  Lines       10818    10822    +4     
=======================================
+ Hits         3357     3359    +2     
- Misses       7461     7463    +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Kiryous Kiryous merged commit 4a58bc4 into main May 11, 2025
17 checks passed
@Kiryous Kiryous deleted the fix/4747-workflow-inputs-disappear branch May 11, 2025 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files. UI User interface related issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[🐛 Bug]: workflow inputs disappear if workflow saved from ui builder
4 participants