-
Notifications
You must be signed in to change notification settings - Fork 981
fix: disappearing workflow inputs in UI builder #4748
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
This PR implements a comprehensive fix for workflow inputs persistence in the UI builder by enhancing the parsing and schema validation logic.
- Added
WorkflowInputSchema
in/keep-ui/entities/workflows/model/schema.ts
to properly validate input properties including name, type, and visual requirements - Updated
/keep-ui/entities/workflows/lib/parser.ts
to handle input extraction and enhancement with proper null checks - Added test coverage in
/keep-ui/entities/workflows/lib/__tests__/parser.test.ts
with newworkflowWithInputs
test fixture - Modified field ordering in
/keep-ui/entities/workflows/lib/yaml-utils.ts
to maintain consistent workflow input positions - Consolidated workflow definition schemas by deprecating
YamlProvider
interface in favor ofYamlWorkflowDefinition
6 file(s) reviewed, 3 comment(s)
Edit PR Review Bot Settings | Greptile
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4748 +/- ##
=======================================
Coverage 31.03% 31.03%
=======================================
Files 93 93
Lines 10818 10822 +4
=======================================
+ Hits 3357 3359 +2
- Misses 7461 7463 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Closes #4747
Before
Screen.Recording.2025-05-08.at.22.12.45.mov
After
Screen.Recording.2025-05-08.at.22.51.50.mov