Skip to content

[keras_hub/src/models/control_net] Add ControlNet #2209

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

SamuelMarks
Copy link
Contributor

@SamuelMarks SamuelMarks commented Apr 8, 2025

Originally implemented by Divum Gupta, then heavily modified by https://github.com/soten355 into MetalDiffusion.

Finally, I extracted out the TensorFlow variant and converted it to Keras 3.

TODO: test!

@sachinprasadhs
Copy link
Collaborator

Thanks for the PR.

Few general comments which needs to be addressed in this PR.

  • Keep all the files under same model folder to maintain flat folder structure which we follow in Keras Hub
  • Remove all ReadMe.md files, if the details are necessary, add it as part of docstring description.
  • Use only absolute imports, no relative imports.
  • Remove all the Copyright mentions.
  • Remove KerasCV usage in the file names and in the class/method names.
  • Keep the file names all lower case and avoid generic naming usage like layers.py, tools.py etc
  • Follow functional model, refer to our usual design practice we follow for the models here https://github.com/keras-team/keras-hub/tree/master/keras_hub/src/models

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants