Add new CSPNet preset and add manual padding. #2212
Conversation
sachinprasadhs
changed the title
There was a problem hiding this comment.
@sachinprasadhs code look good except for one minor comment. Are we sure this works with the older cspnet presets?
| self.converter = convert_resnet | ||
| elif "csp" in architecture: | ||
| elif architecture in ( |
There was a problem hiding this comment.
can we just flip the order of the if and else if? This will be hard to maintain.
There was a problem hiding this comment.
Actually maybe better would be to switch all these checks to architecture.startswith("restnet").
You would need two starts with, darknet and csp, joined with an and I guess
There was a problem hiding this comment.
Makes sense, this would be lot better, made the changes. Thank you.
| @@ -16,9 +16,9 @@ class TimmPresetLoader(PresetLoader): | |||
| def __init__(self, preset, config): | |||
| super().__init__(preset, config) | |||
| architecture = self.config["architecture"] | |||
| if "resnet" in architecture: | |||
| if architecture.startswith("resnet"): | |||
There was a problem hiding this comment.
Can you actually make the startswith change for every elif below? I think it will be a safer and less confusing way to check this overall.
-infinstead ofzeropaddingbeforemaxpoolingto handle edge case scenario to consider negative values from Leaky Relu activation output.