Skip to content

[OpenVINO Backend] support while_loop #21369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2025

Conversation

Mohamed-Ashraf273
Copy link
Contributor

Hi @rkazants ,
I've supported ops.while_loop, and it is ready for review.

@codecov-commenter
Copy link

codecov-commenter commented Jun 9, 2025

Codecov Report

Attention: Patch coverage is 91.52542% with 5 lines in your changes missing coverage. Please review.

Project coverage is 77.77%. Comparing base (771b001) to head (4aef927).
Report is 11 commits behind head on master.

Files with missing lines Patch % Lines
keras/src/backend/openvino/core.py 91.52% 3 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #21369      +/-   ##
==========================================
- Coverage   82.70%   77.77%   -4.94%     
==========================================
  Files         565      565              
  Lines       54894    55129     +235     
  Branches     8517     8585      +68     
==========================================
- Hits        45398    42874    -2524     
- Misses       7415    10231    +2816     
+ Partials     2081     2024      -57     
Flag Coverage Δ
keras 77.61% <91.52%> (-4.90%) ⬇️
keras-jax ?
keras-numpy 58.60% <0.00%> (-0.12%) ⬇️
keras-openvino 33.53% <91.52%> (-0.01%) ⬇️
keras-tensorflow 63.83% <0.00%> (-0.13%) ⬇️
keras-torch 63.46% <0.00%> (-0.15%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Mohamed-Ashraf273
Copy link
Contributor Author

Hi @rkazants ,
I've modified ops.while_loop as you suggested and it is ready for review.

Copy link
Contributor

@rkazants rkazants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fchollet, looks good to me. Recommend to merge

Copy link
Collaborator

@fchollet fchollet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@google-ml-butler google-ml-butler bot added kokoro:force-run ready to pull Ready to be merged into the codebase labels Jun 20, 2025
@github-project-automation github-project-automation bot moved this from Assigned Reviewer to Approved by Reviewer in PR Queue Jun 20, 2025
@fchollet fchollet merged commit fa3e8df into keras-team:master Jun 20, 2025
7 checks passed
@google-ml-butler google-ml-butler bot removed awaiting review ready to pull Ready to be merged into the codebase labels Jun 20, 2025
@github-project-automation github-project-automation bot moved this from Approved by Reviewer to Merged in PR Queue Jun 20, 2025
@Mohamed-Ashraf273 Mohamed-Ashraf273 deleted the support_while_loop branch June 20, 2025 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

5 participants