Critical typo: squeeze the y_pred tensor even when it’s the same rank and shape as the y_pred tensor should be == instead of != #719
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… and shape as the y_pred tensor should be == instead of != Current behavior will squeeze the y_pred tensor even when it’s the same rank and shape as the y_pred tensor. The issue is that the code is written wrong. Read the code comments and what it’s supposed to do (only squeeze when the ranks differ by exactly 1 and not squeeze for situations of equal rank). Yet the code’s if statements will squeeze whenever the ranks are equal, which is wrong from what I can tell. the line: if (y_pred_rank - y_true_rank != 1) or y_pred_shape[-1] == 1: should be: if (y_pred_rank - y_true_rank == 1) or y_pred_shape[-1] == 1:
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
|
@rodriguesk, |
|
Hi, yes, I originally brought this up to tensorflow repo. Looks like they
have taken the lead for making an issue for this repo. I didn’t realize .
You can close whichever one is best.
…On Mon, Jan 22, 2024 at 12:30 AM tilakrayal ***@***.***> wrote:
*External Email*
@rodriguesk <https://github.com/rodriguesk>,
This PR is a duplicate of the other PR #715
<#715> which is under process.
Could you please confirm and feel free to close the PR. Thank you for the
contribution!
—
Reply to this email directly, view it on GitHub
<#719 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AEXL62TBVAC3FB3CZTDIQT3YPYPRTAVCNFSM6AAAAABB335GP6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMBTGQ4DINBQG4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
@rodriguesk, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current behavior will squeeze the y_pred tensor even when it’s the same rank and shape as the y_pred tensor.
The issue is that the code is written wrong. Read the code comments and what it’s supposed to do (only squeeze when the ranks differ by exactly 1 and not squeeze for situations of equal rank). Yet the code’s if statements will squeeze whenever the ranks are equal, which is wrong from what I can tell.
the line:
if (y_pred_rank - y_true_rank != 1) or y_pred_shape[-1] == 1:should be:if (y_pred_rank - y_true_rank == 1) or y_pred_shape[-1] == 1: