Skip to content

lava_callback: Add patch upload support to /patchset endpoint #1082

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

lava_callback: Add patch upload support to /patchset endpoint #1082

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 22 additions & 7 deletions src/lava_callback.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,6 +174,14 @@ def _upload_log(log_parser, job_node, storage):
return _upload_file(storage, job_node, src, 'log.txt.gz')


def _upload_patch(data, upload_id, filename, storage):
with tempfile.TemporaryDirectory() as tmp_dir:
src = os.path.join(tmp_dir, filename)
with open(src, 'wt') as f:
f.write(data)
return _upload_file(storage, upload_id, src, filename)


@app.get('/')
async def read_root():
page = '''
Expand Down Expand Up @@ -675,6 +683,11 @@ async def patchset(data: PatchSet, request: Request,
item['message'] = 'Node is not a checkout'
return JSONResponse(content=item, status_code=400)

# Maybe add field who requested the patchset?
treeidsrc = node['data']['kernel_revision']['url'] + \
node['data']['kernel_revision']['branch'] + str(datetime.now())
treeid = hashlib.sha256(treeidsrc.encode()).hexdigest()

# validate patch URL
if data.patchurl:
if isinstance(data.patchurl, list):
Expand All @@ -688,20 +701,22 @@ async def patchset(data: PatchSet, request: Request,
else:
return 'Invalid patch URL type', 400
elif data.patch:
# We need to implement upload to storage and return URL
item['message'] = 'Not implemented yet'
return JSONResponse(content=item, status_code=501)
if isinstance(data.patch, list):
data.patchurl = []
upload_id = {
'name': 'patchset',
'id': treeid,
}
for i, patch in enumerate(data.patch):
patchurl = _upload_patch(patch, upload_id, f'patch{i}', storage)
data.patchurl.append(patchurl)
else:
item['message'] = 'Missing patch URL or patch'
return JSONResponse(content=item, status_code=400)

# Now we can submit custom patchset node to the API
# Maybe add field who requested the patchset?
timeout = 300
patchset_timeout = datetime.utcnow() + timedelta(minutes=timeout)
treeidsrc = node['data']['kernel_revision']['url'] + \
node['data']['kernel_revision']['branch'] + str(datetime.now())
treeid = hashlib.sha256(treeidsrc.encode()).hexdigest()
# copy node to newnode
newnode = node.copy()
# delete some fields, like id, created, updated, timeout
Expand Down