Skip to content

Enable rt-stable builds in new KernelCI #645

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 2, 2024

Conversation

musamaanjum
Copy link
Contributor

See the description in individual commits.

@musamaanjum
Copy link
Contributor Author

@igaw FYI

@musamaanjum musamaanjum changed the title Enable rt-stable builds Enable rt-stable builds in new KernelCI Jun 14, 2024
@JenySadadia JenySadadia added the staging-skip Don't test automatically on staging.kernelci.org label Jun 17, 2024
@JenySadadia
Copy link
Collaborator

This is breaking staging:

Attaching to kernelci-pipeline-trigger
kernelci-pipeline-trigger | Traceback (most recent call last):
kernelci-pipeline-trigger |   File "/home/kernelci/./pipeline/trigger.py", line 179, in <module>
kernelci-pipeline-trigger |     configs = kernelci.config.load(yaml_configs)
kernelci-pipeline-trigger |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
kernelci-pipeline-trigger |   File "/usr/local/lib/python3.11/site-packages/kernelci/config/__init__.py", line 192, in load
kernelci-pipeline-trigger |     return load_data(data)
kernelci-pipeline-trigger |            ^^^^^^^^^^^^^^^
kernelci-pipeline-trigger |   File "/usr/local/lib/python3.11/site-packages/kernelci/config/__init__.py", line 174, in load_data
kernelci-pipeline-trigger |     config.update(mod.from_yaml(data, filters))
kernelci-pipeline-trigger |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^
kernelci-pipeline-trigger |   File "/usr/local/lib/python3.11/site-packages/kernelci/legacy/config/__init__.py", line 20, in from_yaml
kernelci-pipeline-trigger |     config.update(build_config.from_yaml(data, filters))
kernelci-pipeline-trigger |                   ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
kernelci-pipeline-trigger |   File "/usr/local/lib/python3.11/site-packages/kernelci/legacy/config/build.py", line 462, in from_yaml
kernelci-pipeline-trigger |     build_configs = {
kernelci-pipeline-trigger |                     ^
kernelci-pipeline-trigger |   File "/usr/local/lib/python3.11/site-packages/kernelci/legacy/config/build.py", line 463, in <dictcomp>
kernelci-pipeline-trigger |     name: BuildConfig.load_from_yaml(
kernelci-pipeline-trigger |           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
kernelci-pipeline-trigger |   File "/usr/local/lib/python3.11/site-packages/kernelci/legacy/config/build.py", line 399, in load_from_yaml
kernelci-pipeline-trigger |     variants = [
kernelci-pipeline-trigger |                ^
kernelci-pipeline-trigger |   File "/usr/local/lib/python3.11/site-packages/kernelci/legacy/config/build.py", line 400, in <listcomp>
kernelci-pipeline-trigger |     BuildVariant.load_from_yaml(variant, name, fragments, b_envs)
kernelci-pipeline-trigger |   File "/usr/local/lib/python3.11/site-packages/kernelci/legacy/config/build.py", line 315, in load_from_yaml
kernelci-pipeline-trigger |     kw['architectures'] = list(
kernelci-pipeline-trigger |                           ^^^^^
kernelci-pipeline-trigger |   File "/usr/local/lib/python3.11/site-packages/kernelci/legacy/config/build.py", line 316, in <genexpr>
kernelci-pipeline-trigger |     Architecture.load_from_yaml(data or {}, name, fragments)
kernelci-pipeline-trigger |   File "/usr/local/lib/python3.11/site-packages/kernelci/legacy/config/build.py", line 179, in load_from_yaml
kernelci-pipeline-trigger |     kw['fragments'] = [fragments[name] for name in cf] if cf else None
kernelci-pipeline-trigger |                       ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
kernelci-pipeline-trigger |   File "/usr/local/lib/python3.11/site-packages/kernelci/legacy/config/build.py", line 179, in <listcomp>
kernelci-pipeline-trigger |     kw['fragments'] = [fragments[name] for name in cf] if cf else None
kernelci-pipeline-trigger |                        ~~~~~~~~~^^^^^^
kernelci-pipeline-trigger | KeyError: 'arm64-chromebook'

@musamaanjum musamaanjum mentioned this pull request Jun 18, 2024
@musamaanjum musamaanjum requested a review from a-wai June 18, 2024 06:15
@musamaanjum musamaanjum force-pushed the stable-rt-builds branch 2 times, most recently from 4e8bd06 to 5284983 Compare June 18, 2024 07:44
@musamaanjum
Copy link
Contributor Author

musamaanjum commented Jun 18, 2024

There was fragments-related error. @JenySadadia could you review it again to see if following has help?

I've updated the format of fragments to use strings (with ', previously it was without '):

fragments:
  - 'abc'

@musamaanjum
Copy link
Contributor Author

musamaanjum commented Jun 18, 2024

@JenySadadia @nuclearcat the error is still present. I'm using fragment in pipeline. Any ideas what's going wrong? The same fragment is working fine in jobs-chromeos.yaml.

Copy rt-stable builds from legacy KernelCI.

Signed-off-by: Muhammad Usama Anjum <[email protected]>
---
Changes:
- Major changes to move to new way of writing kbuild jobs
@musamaanjum
Copy link
Contributor Author

Thanks @pawiecz. I've updated the PR.

Tested locally seem to be working now. Removig staging-skip tag. Feel free to add it again if it causes issues.

@musamaanjum musamaanjum removed the staging-skip Don't test automatically on staging.kernelci.org label Jul 1, 2024
@musamaanjum musamaanjum dismissed pawiecz’s stale review July 1, 2024 08:13

Updated the PR

Copy link
Contributor

@pawiecz pawiecz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not too familiar with result-summary tool but all 3 patches look good to me 👍

@musamaanjum
Copy link
Contributor Author

musamaanjum commented Jul 2, 2024

@pawiecz @nuclearcat
I'm getting results on some branches.
kbuilds.html.txt

I've not enabled stable-rt builds for i386 and riscv. But still, I can find results for these architectures. I'll check the PR.

I've looked at the PR and I've not enabled these builds on i386 and riscv. What reason do you see for this behaviour?

@nuclearcat nuclearcat added this pull request to the merge queue Jul 2, 2024
Merged via the queue into kernelci:main with commit 3814188 Jul 2, 2024
3 checks passed
@musamaanjum musamaanjum deleted the stable-rt-builds branch July 2, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants