Some fixes to the HTMX module #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hyperscript is not used on the page and Hyperscript as such is only one of many different scripting options used with HTMX (and arguably the least popular I think). Vanilla js or Alpine.js would be better defaults if scripting is needed I think.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not converting
pageanduito macros in the interest of speed, but the previous versions didn't handle correctly the case when you pass an opts-map to the functions (since the spliced content is passed as a single parameter to html5 macros).If you could
applya macro I would have gone for that, but don't know of any other obvious way to accomplish this.Also, in the case of current Hiccup2 the
htmlfunction returns a compiled representation, not a string. I don't think the former is a valid Ring response body type.Re the last commit, I think 'ui' is too generic a name. 'Pagelet' actually seems to be an established term for these kind of partial pages (and it's sounds much cuter).