feat: receiver verticle now has a grace period before closing

[Cali0707]

Fixes #1684

Proposed Changes

• Add parameter to ReceiverVerticleFactory for how long to wait before closing the http servers in the receiver
• Use timeout in the receiver stop handler to wait until the grace period has finished before closing the servers

Release Note

The receiver http/https servers now wait for 20 seconds after receiving SIGTERM before closing, helping with more graceful shutdown

[Cali0707]

/cc @pierDipi

[knative-prow]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Cali0707

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS [Cali0707]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.69%. Comparing base (aacc057) to head (17674ca).
Report is 201 commits behind head on main.

❗ There is a different number of reports uploaded between BASE (aacc057) and HEAD (17674ca). Click for more details.

HEAD has 1 upload less than BASE

Flag	BASE (aacc057)	HEAD (17674ca)
java-unittests	1	0

Additional details and impacted files

@@              Coverage Diff              @@
##               main    #3896       +/-   ##
=============================================
- Coverage     73.70%   49.69%   -24.02%     
=============================================
  Files           100      246      +146     
  Lines          3419    14849    +11430     
  Branches        292        0      -292     
=============================================
+ Hits           2520     7379     +4859     
- Misses          723     6711     +5988     
- Partials        176      759      +583     

Flag	Coverage Δ
java-unittests	?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[Cali0707]

/retest-required

[knative-prow]

@Cali0707: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
reconciler-tests-namespaced-broker_eventing-kafka-broker_main	17674ca	link	true	/test reconciler-tests-namespaced-broker

Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

[knative-prow-robot]

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[github-actions]

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Reopen with /reopen. Mark as fresh by adding the
comment /remove-lifecycle stale.

[github-actions]

This Pull Request is stale because it has been open for 90 days with
no activity. It will automatically close after 30 more days of
inactivity. Reopen with /reopen. Mark as fresh by adding the
comment /remove-lifecycle stale.

[lamluongbinh]

Hi @Cali0707, I wanted to check on the status of this MR.

We found some timeout errors occurring while the Knative receiver is scaling, and while pods are relocated to another node during an upgrade.

It seems we need to implement graceful shutdown handling in the receiver.

Could you help review this feature again and make it possible for the next version of Knative?

As a workaround, I have patched the receiver deployment to wait 20 seconds before terminating.

    spec:
      containers:
        - name: kafka-broker-receiver
          lifecycle:
            preStop:
              exec:
                command: ["bash", "-c", "sleep 20"]

Thanks!