Skip to content

Testimonials page #4781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Feb 23, 2022
Merged

Testimonials page #4781

merged 8 commits into from
Feb 23, 2022

Conversation

gabo1208
Copy link
Member

Fixes #4667

@knative-prow-robot knative-prow-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 23, 2022
@netlify
Copy link

netlify bot commented Feb 23, 2022 •
edited
Loading

✔️ Deploy Preview for knative ready!

🔨 Explore the source changes: d945af3

🔍 Inspect the deploy log: https://app.netlify.com/sites/knative/deploys/621695c26168150009e0f9a7

😎 Browse the preview: https://deploy-preview-4781--knative.netlify.app

@knative-prow-robot knative-prow-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Feb 23, 2022
@knative-prow-robot knative-prow-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Feb 23, 2022
@csantanapr
Copy link
Member

it looks very good @gabo1208
We just need to adjust the location.
We discussed in DUX meetings where to place "testimonials". rename "Case Studies" with "About"
See for more details #4779

@csantanapr
Copy link
Member

/hold

@knative-prow-robot knative-prow-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 23, 2022
@csantanapr
Copy link
Member

/approve

@knative-prow-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: csantanapr, gabo1208

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow-robot knative-prow-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Feb 23, 2022
csantanapr
csantanapr reviewed Feb 23, 2022
View reviewed changes
csantanapr
csantanapr reviewed Feb 23, 2022
View reviewed changes
config/nav.yml Outdated
@@ -239,6 +239,8 @@ nav:
- Client: reference/client/README.md
- Concepts:
- Duck types: reference/concepts/duck-typing.md
- About:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't want a new menu "About"

I think this is what we are looking for

    - Community:
      - Welcome to the community: community/README.md
      - Contribute to Knative: community/contributing.md
      - About the community: community/about.md
    - About:
      - Testimonials: about/testimonials.md
      - Case studies:
        - about/case-studies/index.md
        - deepc: about/case-studies/deepc.md
        - Outfit7: about/case-studies/outfit7.md
        - Puppet: about/case-studies/puppet.md
    - Blog: /blog/

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing that is missing here is the index on the case studies, for now I'll redirect it to the deepc as it is right now

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah redirect to deepc one

@csantanapr
Copy link
Member

again thank you @gabo1208
/unhold
/lgtm

@knative-prow-robot knative-prow-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Feb 23, 2022
@knative-prow-robot knative-prow-robot added the lgtm Indicates that a PR is ready to be merged. label Feb 23, 2022
@knative-prow-robot knative-prow-robot merged commit ab640e1 into knative:main Feb 23, 2022
@csantanapr
Copy link
Member

/cherry-pick release-1.2

@knative-prow-robot
Copy link
Contributor

@csantanapr: new pull request created: #4782

In response to this:

/cherry-pick release-1.2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@knative-prow-robot knative-prow-robot mentioned this pull request Feb 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csantanapr csantanapr csantanapr left review comments

Assignees

@csantanapr csantanapr

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add "Testimonials" page to knative.dev website
3 participants
@gabo1208 @csantanapr @knative-prow-robot