Skip to content

Create Concepts section #5155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jul 29, 2022
Merged

Create Concepts section #5155

merged 6 commits into from
Jul 29, 2022

Conversation

abrennan89
Copy link
Contributor

@abrennan89 abrennan89 commented Jul 29, 2022

Partial work for #5054 + #5116

Proposed Changes

  • Create new top level Concepts section
  • Move Ducktyping docs
  • Create snippets for serving and eventing explanations; content re-use

Preview links

@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 29, 2022
@knative-prow
Copy link

knative-prow bot commented Jul 29, 2022

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: abrennan89

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 29, 2022
@netlify
Copy link

netlify bot commented Jul 29, 2022

Deploy Preview for knative ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit f1149d5
🔍 Latest deploy log https://app.netlify.com/sites/knative/deploys/62e3df3a97bfae00096c295e
😎 Deploy Preview https://deploy-preview-5155--knative.netlify.app/docs/eventing
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

Copy link
Contributor

@psschwei psschwei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Jul 29, 2022
@knative-prow knative-prow bot merged commit 2c8f9e3 into knative:main Jul 29, 2022
@abrennan89 abrennan89 deleted the concepts branch August 26, 2022 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants