Skip to content

Migrate golanglint-ci config to v2 #8557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 11, 2025

Conversation

creydr
Copy link
Member

@creydr creydr commented Apr 11, 2025

No description provided.

@knative-prow knative-prow bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Apr 11, 2025
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 11, 2025
@creydr creydr force-pushed the update-golanglint-ci-config branch from 7d5f1d7 to 9400780 Compare April 11, 2025 13:28
Copy link

codecov bot commented Apr 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.33%. Comparing base (bbc9696) to head (9400780).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8557   +/-   ##
=======================================
  Coverage   52.33%   52.33%           
=======================================
  Files         397      397           
  Lines       24923    24923           
=======================================
  Hits        13043    13043           
  Misses      11094    11094           
  Partials      786      786           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dprotaso
Copy link
Member

/lgtm
/approve

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 11, 2025
Copy link

knative-prow bot commented Apr 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: creydr, dprotaso

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot merged commit 6365d89 into knative:main Apr 11, 2025
32 checks passed
@creydr
Copy link
Member Author

creydr commented Apr 15, 2025

/cherry-pick release-v1.16
/cherry-pick release-v1.17

@creydr
Copy link
Member Author

creydr commented Apr 15, 2025

/cherry-pick release-1.16
/cherry-pick release-1.17

@knative-prow-robot
Copy link
Contributor

@creydr: cannot checkout release-v1.16: error checking out "release-v1.16": exit status 1 error: pathspec 'release-v1.16' did not match any file(s) known to git

In response to this:

/cherry-pick release-v1.16
/cherry-pick release-v1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow-robot
Copy link
Contributor

@creydr: #8557 failed to apply on top of branch "release-1.16":

Applying: Migrate golanglint-ci config to v2
Using index info to reconstruct a base tree...
M	.golangci.yaml
Falling back to patching base and 3-way merge...
Auto-merging .golangci.yaml
CONFLICT (content): Merge conflict in .golangci.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 Migrate golanglint-ci config to v2

In response to this:

/cherry-pick release-1.16
/cherry-pick release-1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow-robot
Copy link
Contributor

@creydr: cannot checkout release-v1.17: error checking out "release-v1.17": exit status 1 error: pathspec 'release-v1.17' did not match any file(s) known to git

In response to this:

/cherry-pick release-v1.16
/cherry-pick release-v1.17

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants