Skip to content

Re-enable build caching for local s2i builds #2772

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

matejvasek
Copy link
Contributor

Changes

  • Re-enable build caching for local s2i builds

@matejvasek matejvasek requested a review from lkingland April 4, 2025 11:34
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 4, 2025
@knative-prow knative-prow bot requested review from dsimansk and jrangelramos April 4, 2025 11:34
@matejvasek matejvasek requested a review from gauron99 April 4, 2025 11:34
@knative-prow knative-prow bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Apr 4, 2025
Copy link
Member

@lkingland lkingland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 4, 2025
Copy link

knative-prow bot commented Apr 4, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lkingland, matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [lkingland,matejvasek]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

codecov bot commented Apr 4, 2025

Codecov Report

Attention: Patch coverage is 62.50000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 62.43%. Comparing base (3e75e25) to head (d7d45ba).
Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
pkg/builders/s2i/builder.go 62.50% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2772      +/-   ##
==========================================
+ Coverage   61.59%   62.43%   +0.84%     
==========================================
  Files         131      131              
  Lines       15793    15800       +7     
==========================================
+ Hits         9727     9865     +138     
+ Misses       5151     4992     -159     
- Partials      915      943      +28     
Flag Coverage Δ
e2e-test 35.32% <0.00%> (-0.02%) ⬇️
e2e-test-oncluster 33.68% <0.00%> (+1.33%) ⬆️
e2e-test-oncluster-runtime 28.08% <0.00%> (?)
e2e-test-runtime-go 25.74% <62.50%> (?)
e2e-test-runtime-node 25.09% <62.50%> (?)
e2e-test-runtime-rust 24.65% <0.00%> (?)
e2e-test-runtime-springboot 24.69% <0.00%> (?)
e2e-test-runtime-typescript 25.18% <62.50%> (?)
integration-tests 48.62% <62.50%> (+1.81%) ⬆️
unit-tests 48.67% <62.50%> (?)
unit-tests-macos-latest ?
unit-tests-ubuntu-latest ?
unit-tests-windows-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants