Skip to content

Make base jammy stack multi-arch #2780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2025

Conversation

matejvasek
Copy link
Contributor

No description provided.

@matejvasek matejvasek requested a review from lkingland April 11, 2025 12:08
Copy link

knative-prow bot commented Apr 11, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: matejvasek

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@knative-prow knative-prow bot requested review from rhuss and vyasgun April 11, 2025 12:08
@knative-prow knative-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 11, 2025
@matejvasek matejvasek requested review from gauron99 and removed request for rhuss and vyasgun April 11, 2025 12:08
@knative-prow knative-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Apr 11, 2025
@matejvasek
Copy link
Contributor Author

PTAL @gauron99 @lkingland

Copy link

codecov bot commented Apr 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 62.43%. Comparing base (b67d8d4) to head (765b71b).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2780      +/-   ##
==========================================
+ Coverage   61.60%   62.43%   +0.83%     
==========================================
  Files         131      131              
  Lines       15793    15793              
==========================================
+ Hits         9729     9861     +132     
+ Misses       5150     4989     -161     
- Partials      914      943      +29     
Flag Coverage Δ
e2e-test 35.34% <ø> (ø)
e2e-test-oncluster 33.69% <ø> (+1.32%) ⬆️
e2e-test-oncluster-runtime 28.10% <ø> (?)
e2e-test-runtime-go 25.71% <ø> (?)
e2e-test-runtime-node 25.07% <ø> (?)
e2e-test-runtime-quarkus 25.16% <ø> (?)
e2e-test-runtime-rust 24.66% <ø> (?)
e2e-test-runtime-springboot 24.70% <ø> (?)
e2e-test-runtime-typescript 25.15% <ø> (?)
integration-tests 48.61% <ø> (+1.81%) ⬆️
unit-tests 48.66% <ø> (?)
unit-tests-macos-latest ?
unit-tests-ubuntu-latest ?
unit-tests-windows-latest ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@matzew
Copy link
Member

matzew commented Apr 14, 2025

/override Code Style / style / Golang / Lint

Copy link

knative-prow bot commented Apr 14, 2025

@matzew: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • /
  • Code
  • Golang
  • Lint
  • Style
  • style

Only the following failed contexts/checkruns were expected:

  • EasyCLA
  • style / Golang / Lint
  • style / suggester / shell
  • style / suggester / yaml
  • tide
  • unit-tests_func_main

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/override Code Style / style / Golang / Lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@matzew
Copy link
Member

matzew commented Apr 14, 2025

/lgtm

/override style / Golang / Lint

Copy link

knative-prow bot commented Apr 14, 2025

@matzew: /override requires failed status contexts, check run or a prowjob name to operate on.
The following unknown contexts/checkruns were given:

  • /
  • Golang
  • Lint
  • style

Only the following failed contexts/checkruns were expected:

  • EasyCLA
  • style / Golang / Lint
  • style / suggester / shell
  • style / suggester / yaml
  • tide
  • unit-tests_func_main

If you are trying to override a checkrun that has a space in it, you must put a double quote on the context.

In response to this:

/lgtm

/override style / Golang / Lint

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot added the lgtm Indicates that a PR is ready to be merged. label Apr 14, 2025
@matzew
Copy link
Member

matzew commented Apr 14, 2025

/override "style / Golang / Lint"

Copy link

knative-prow bot commented Apr 14, 2025

@matzew: Overrode contexts on behalf of matzew: style / Golang / Lint

In response to this:

/override "style / Golang / Lint"

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@knative-prow knative-prow bot merged commit d028013 into knative:main Apr 14, 2025
38 of 39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants