-
Notifications
You must be signed in to change notification settings - Fork 332
Allow override QPS and Burst via flag #1778
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/cc dprotaso mattmoor |
Codecov Report
@@ Coverage Diff @@
## master #1778 +/- ##
==========================================
- Coverage 68.25% 68.13% -0.12%
==========================================
Files 218 218
Lines 9295 9305 +10
==========================================
- Hits 6344 6340 -4
- Misses 2636 2648 +12
- Partials 315 317 +2
Continue to review full report at Codecov.
|
Ref: #1672
/retest |
/lgtm |
This will be lost when #1772 lands. |
Flakes: #1779 |
Add `--kube-api-qps` and `--kube-api-burst` command-line flags to control client QPS and Burst respectively. The default value is set to 0 to keep backward compatibility. Signed-off-by: Pierangelo Di Pilato <[email protected]>
Ref: #1672
/retest |
Signed-off-by: Pierangelo Di Pilato <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
/retest
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: n3wscott, pierDipi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes #1700
Add
--kube-api-qps
and--kube-api-burst
command-line flagsto control client QPS and Burst respectively.
The default value is set to 0 to keep backward compatibility.