Skip to content

fix: ec pipeline conforma violation in build-template.go #1520

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

cuipinghuo
Copy link
Contributor

@cuipinghuo cuipinghuo commented Feb 25, 2025

Description

exclude slsa_source_correlated.source_code_reference_provided to fix conforma violation

Issue ticket number and link

https://issues.redhat.com/browse/KONFLUX-5787

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added meaningful description with JIRA/GitHub issue key(if applicable), for example HASSuiteDescribe("STONE-123456789 devfile source")
  • I have updated labels (if needed)

Copy link

openshift-ci bot commented Feb 25, 2025

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@cuipinghuo cuipinghuo marked this pull request as ready for review February 26, 2025 14:26
@openshift-ci openshift-ci bot requested review from chmeliik and tnevrlka February 26, 2025 14:26
@cuipinghuo cuipinghuo force-pushed the ec-build-fix branch 4 times, most recently from 20d9244 to 8fc4d79 Compare March 3, 2025 16:55
@cuipinghuo cuipinghuo changed the title fix: KONFLUX-5787 fix: ec pipeline flaky in build-template.go Mar 3, 2025
@cuipinghuo cuipinghuo changed the title fix: ec pipeline flaky in build-template.go fix: ec pipeline voliation in build-template.go Apr 18, 2025
@cuipinghuo cuipinghuo changed the title fix: ec pipeline voliation in build-template.go fix: ec pipeline conforma violation in build-template.go Apr 18, 2025
@simonbaird
Copy link
Contributor

/approve

Copy link

openshift-ci bot commented Apr 18, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: simonbaird
Once this PR has been reviewed and has the lgtm label, please assign flacatus for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@simonbaird
Copy link
Contributor

/lgtm

Copy link

openshift-ci bot commented Apr 18, 2025

New changes are detected. LGTM label has been removed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants