Plaited 7.2.0 #1875
Merged
Plaited 7.2.0 #1875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here's the comparison (left new keyed, right previous old): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Fix] upgrade to 7.2.0 to fix performance regressions
Renames defineTemplate to defineElement to prevent confusion around usage of new useTemplate utility. This utility is a renamed/refactored clone helper focused on just HTMLTemplateElements. The version 5.3.0 clone helper was originally inspired by SolidJS's For component and I totally forgot why when I removed it.
This PR should restore performance, or get me close to 5.3.0, while keeping with additional features in v7. I expect this to be the last PR for quite awhile. Making SSR first framework perform client side this well has been a challenge.