Sourcery refactored main branch #1
Open
+15
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Comment on lines
-15
to
+17
| # Yapılandırmanın önceden kullanılan değişkeni kullanarak düzenlenip düzenlenmediğini kontrol edin. | ||
| # Temel olarak, yapılandırma dosyası için kontrol. | ||
| AYAR_KONTROL = os.environ.get("___________LUTFEN_______BU_____SATIRI_____SILIN__________", None) | ||
|
|
||
| if AYAR_KONTROL: | ||
| if AYAR_KONTROL := os.environ.get( | ||
| "___________LUTFEN_______BU_____SATIRI_____SILIN__________", None | ||
| ): |
There was a problem hiding this comment.
Lines 15-19 refactored with the following changes:
- Use named expression to simplify assignment and conditional (
use-named-expression)
This removes the following comments ( why? ):
# Yapılandırmanın önceden kullanılan değişkeni kullanarak düzenlenip düzenlenmediğini kontrol edin.
# Temel olarak, yapılandırma dosyası için kontrol.
| self.konsol.print("✅"+yazi, style="bold green", width=70, justify="center") | ||
| self.konsol.print(f"✅{yazi}", style="bold green", width=70, justify="center") |
There was a problem hiding this comment.
Function Amil.basarili_is refactored with the following changes:
- Use f-string instead of string concatenation (
use-fstring-for-concatenation)
Comment on lines
-173
to
+184
| if type == "str" or type == "string": | ||
| return str(self.konsol.input(f"[red]{self.oturum}:[/][cyan]~/../{self.get_location()[-2] + '/' + self.get_location()[-1]}[/]{' [green][[/][yellow] ' + info + ' [/][green]][/] ' if info else ''}[cyan]>> ")) | ||
| elif type == "int" or type == "integer": | ||
| return int(self.konsol.input(f"[red]{self.oturum}:[/][cyan]~/../{self.get_location()[-2] + '/' + self.get_location()[-1]}[/]{' [green][[/][yellow] ' + info + ' [/][green]][/] ' if info else ''}[cyan]>> ")) | ||
| if type in {"str", "string"} or type not in ["int", "integer"]: | ||
| return str( | ||
| self.konsol.input( | ||
| f"[red]{self.oturum}:[/][cyan]~/../{self.get_location()[-2]}/{self.get_location()[-1]}[/]{f' [green][[/][yellow] {info} [/][green]][/] ' if info else ''}[cyan]>> " | ||
| ) | ||
| ) | ||
| else: | ||
| return str(self.konsol.input(f"[red]{self.oturum}:[/][cyan]~/../{self.get_location()[-2] + '/' + self.get_location()[-1]}[/]{' [green][[/][yellow] ' + info + ' [/][green]][/] ' if info else ''}[cyan]>> ")) | ||
| return int( | ||
| self.konsol.input( | ||
| f"[red]{self.oturum}:[/][cyan]~/../{self.get_location()[-2]}/{self.get_location()[-1]}[/]{f' [green][[/][yellow] {info} [/][green]][/] ' if info else ''}[cyan]>> " | ||
| ) | ||
| ) |
There was a problem hiding this comment.
Function Amil.option refactored with the following changes:
- Merge duplicate blocks in conditional (
merge-duplicate-blocks) - Simplify unnecessary nesting, casting and constant values in f-strings [×2] (
simplify-fstring-formatting) - Use f-string instead of string concatenation [×8] (
use-fstring-for-concatenation) - Remove redundant conditional (
remove-redundant-if) - Replace multiple comparisons of same variable with
inoperator [×2] (merge-comparisons) - Use set when checking membership of a collection of literals (
collection-into-set)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branch
mainrefactored by Sourcery.If you're happy with these changes, merge this Pull Request using the Squash and merge strategy.
See our documentation here.
Run Sourcery locally
Reduce the feedback loop during development by using the Sourcery editor plugin:
Review changes via command line
To manually merge these changes, make sure you're on the
mainbranch, then run:Help us improve this pull request!